Skip to content

Bumping node archives to latest stable versions #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loosebazooka merged 1 commit into from
Aug 1, 2025
Merged

Bumping node archives to latest stable versions #1830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 37 additions & 37 deletions MODULE.bazel.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion nodejs/testdata/nodejs22.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ commandTests:
- name: nodejs
command: "/nodejs/bin/node"
args: ["--version"]
expectedOutput: ["v22.17.1"]
expectedOutput: ["v22.18.0"]
2 changes: 1 addition & 1 deletion nodejs/testdata/nodejs24.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ commandTests:
- name: nodejs
command: "/nodejs/bin/node"
args: ["--version"]
expectedOutput: ["v24.4.1"]
expectedOutput: ["v24.5.0"]
72 changes: 36 additions & 36 deletions private/extensions/node.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,90 +149,90 @@ def _node_impl(module_ctx):

node_archive(
name = "nodejs22_amd64",
sha256 = "cfb6ac0cf339825fe36efd1f18a79016b02aca19fbfa6c9547c57e27dc09f6ea",
strip_prefix = "node-v22.17.1-linux-x64/",
urls = ["https://nodejs.org/dist/v22.17.1/node-v22.17.1-linux-x64.tar.gz"],
version = "22.17.1",
sha256 = "a2e703725d8683be86bb5da967bf8272f4518bdaf10f21389e2b2c9eaeae8c8a",
strip_prefix = "node-v22.18.0-linux-x64/",
urls = ["https://nodejs.org/dist/v22.18.0/node-v22.18.0-linux-x64.tar.gz"],
version = "22.18.0",
architecture = "amd64",
control = "//nodejs:control",
)

node_archive(
name = "nodejs22_arm64",
sha256 = "f53510706998cf044f634190416f0588e7e1937aecea938768952e0f0ac1f41b",
strip_prefix = "node-v22.17.1-linux-arm64/",
urls = ["https://nodejs.org/dist/v22.17.1/node-v22.17.1-linux-arm64.tar.gz"],
version = "22.17.1",
sha256 = "d415eeea90a2fdb60c66dd386b258acbfc4d1fa4720a8df5dea7369fbdbcddee",
strip_prefix = "node-v22.18.0-linux-arm64/",
urls = ["https://nodejs.org/dist/v22.18.0/node-v22.18.0-linux-arm64.tar.gz"],
version = "22.18.0",
architecture = "arm64",
control = "//nodejs:control",
)

node_archive(
name = "nodejs22_arm",
sha256 = "520dcd113eca345074cab3c3e7c23b93517a6a0a22fac98e843b195fcfdcc5d7",
strip_prefix = "node-v22.17.1-linux-armv7l/",
urls = ["https://nodejs.org/dist/v22.17.1/node-v22.17.1-linux-armv7l.tar.gz"],
version = "22.17.1",
sha256 = "57830914581dc3640e8d95378b76c6910860f42531959e4e88eb445e0cd982b0",
strip_prefix = "node-v22.18.0-linux-armv7l/",
urls = ["https://nodejs.org/dist/v22.18.0/node-v22.18.0-linux-armv7l.tar.gz"],
version = "22.18.0",
architecture = "arm",
control = "//nodejs:control",
)

node_archive(
name = "nodejs22_ppc64le",
sha256 = "c07ee9fb0c0396f5551a9c0228570fdb45ebf21ba9723f7098671320f364a202",
strip_prefix = "node-v22.17.1-linux-ppc64le/",
urls = ["https://nodejs.org/dist/v22.17.1/node-v22.17.1-linux-ppc64le.tar.gz"],
version = "22.17.1",
sha256 = "38f965cbaa5e730dbd3b1afe895cfdb86da96371474827d05d847d338a0c9c97",
strip_prefix = "node-v22.18.0-linux-ppc64le/",
urls = ["https://nodejs.org/dist/v22.18.0/node-v22.18.0-linux-ppc64le.tar.gz"],
version = "22.18.0",
architecture = "ppc64le",
control = "//nodejs:control",
)

node_archive(
name = "nodejs22_s390x",
sha256 = "5ee94f6e421a383435c2f96b8e5742ad0eea54a851dc6b66583fc28a2f84cd33",
strip_prefix = "node-v22.17.1-linux-s390x/",
urls = ["https://nodejs.org/dist/v22.17.1/node-v22.17.1-linux-s390x.tar.gz"],
version = "22.17.1",
sha256 = "f3578b0e7cdf247045f6eeb766febd74942954352161102cb6040a4d4c3b4c3c",
strip_prefix = "node-v22.18.0-linux-s390x/",
urls = ["https://nodejs.org/dist/v22.18.0/node-v22.18.0-linux-s390x.tar.gz"],
version = "22.18.0",
architecture = "s390x",
control = "//nodejs:control",
)

node_archive(
name = "nodejs24_amd64",
sha256 = "063f2eb299ba60e3fc9b424d8e87d0e2f6be84b39bdeadc421ee2865914c498b",
strip_prefix = "node-v24.4.1-linux-x64/",
urls = ["https://nodejs.org/dist/v24.4.1/node-v24.4.1-linux-x64.tar.gz"],
version = "24.4.1",
sha256 = "369f2a3668dde7e324697040fafdcf442fd198b8c102317145417b3c83a9794a",
strip_prefix = "node-v24.5.0-linux-x64/",
urls = ["https://nodejs.org/dist/v24.5.0/node-v24.5.0-linux-x64.tar.gz"],
version = "24.5.0",
architecture = "amd64",
control = "//nodejs:control",
)

node_archive(
name = "nodejs24_arm64",
sha256 = "fde5421e2652e51199bc678e1e6c4d80bbb4c55337ec0a82206568517e9792ef",
strip_prefix = "node-v24.4.1-linux-arm64/",
urls = ["https://nodejs.org/dist/v24.4.1/node-v24.4.1-linux-arm64.tar.gz"],
version = "24.4.1",
sha256 = "c643c118d907c8db42a677a12789eb5d55ad6de4b8e2c11bab08dbd23852da2e",
strip_prefix = "node-v24.5.0-linux-arm64/",
urls = ["https://nodejs.org/dist/v24.5.0/node-v24.5.0-linux-arm64.tar.gz"],
version = "24.5.0",
architecture = "arm64",
control = "//nodejs:control",
)

node_archive(
name = "nodejs24_ppc64le",
sha256 = "b4ee745e4d8a2c3f3a793a50695d769322b81c79f2b7b79c2a359bca892a0f36",
strip_prefix = "node-v24.4.1-linux-ppc64le/",
urls = ["https://nodejs.org/dist/v24.4.1/node-v24.4.1-linux-ppc64le.tar.gz"],
version = "24.4.1",
sha256 = "7f45e28aedae5a4077c04fa1934268c9e3620dcfb105624517c2410ca1deb00d",
strip_prefix = "node-v24.5.0-linux-ppc64le/",
urls = ["https://nodejs.org/dist/v24.5.0/node-v24.5.0-linux-ppc64le.tar.gz"],
version = "24.5.0",
architecture = "ppc64le",
control = "//nodejs:control",
)

node_archive(
name = "nodejs24_s390x",
sha256 = "8c9a680c3ae7c8b4a02f55faa055d960ab639a67b257efe7a466d49934746630",
strip_prefix = "node-v24.4.1-linux-s390x/",
urls = ["https://nodejs.org/dist/v24.4.1/node-v24.4.1-linux-s390x.tar.gz"],
version = "24.4.1",
sha256 = "1d151244f5502ff7e72271e603889d789dec021f0cb28148d90f4a8ce89eaf30",
strip_prefix = "node-v24.5.0-linux-s390x/",
urls = ["https://nodejs.org/dist/v24.5.0/node-v24.5.0-linux-s390x.tar.gz"],
version = "24.5.0",
architecture = "s390x",
control = "//nodejs:control",
Comment on lines 151 to 237
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The node_archive definitions are highly repetitive. Consider refactoring to use a data structure and a loop to generate these definitions. This would improve maintainability, especially when updating to new Node.js versions. For example, create a dictionary mapping versions to their corresponding architectures and checksums, then iterate through this dictionary to generate the node_archive calls.

)
Expand Down
Loading