Skip to content

Bumping node archives to latest stable versions#1843

Merged
loosebazooka merged 1 commit intomainfrom
update-node-archives
Aug 15, 2025
Merged

Bumping node archives to latest stable versions#1843
loosebazooka merged 1 commit intomainfrom
update-node-archives

Conversation

@distroless-bot
Copy link
Collaborator

Signed-off-by: Distroless Bot distroless-bot@google.com

Signed-off-by: Distroless Bot <distroless-bot@google.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @distroless-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the Node.js 24 archives to their latest stable version, 24.6.0. This ensures that the project utilizes the most current and stable Node.js release, incorporating the necessary updates to archive checksums, download URLs, and corresponding test expectations for various architectures.

Highlights

  • Node.js Version Update: Updated Node.js 24 from version 24.5.0 to 24.6.0 across all supported architectures.
  • Archive Checksums: Updated SHA256 checksums for all Node.js 24 archives (amd64, arm64, ppc64le, s390x) to reflect the new 24.6.0 binaries.
  • Download URLs: Modified download URLs to point to the Node.js v24.6.0 archives.
  • Test Configuration: Adjusted the nodejs24.yaml test configuration to expect Node.js version v24.6.0.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Node.js archives to the latest stable version, v24.6.0. The changes correctly update the version number in the test file and the checksums, URLs, and version strings in the Bazel build file.

I've added one suggestion to refactor the private/extensions/node.bzl file. By using a loop and a dictionary for the architecture-specific details, we can significantly reduce code duplication and improve the maintainability of the file, making future updates easier.

Comment on lines 200 to 238
node_archive(
name = "nodejs24_amd64",
sha256 = "369f2a3668dde7e324697040fafdcf442fd198b8c102317145417b3c83a9794a",
strip_prefix = "node-v24.5.0-linux-x64/",
urls = ["https://nodejs.org/dist/v24.5.0/node-v24.5.0-linux-x64.tar.gz"],
version = "24.5.0",
sha256 = "352ddbc48b586c11f018ec9b886225117909ea93e05b4a04a6db32f3e63d0281",
strip_prefix = "node-v24.6.0-linux-x64/",
urls = ["https://nodejs.org/dist/v24.6.0/node-v24.6.0-linux-x64.tar.gz"],
version = "24.6.0",
architecture = "amd64",
control = "//nodejs:control",
)

node_archive(
name = "nodejs24_arm64",
sha256 = "c643c118d907c8db42a677a12789eb5d55ad6de4b8e2c11bab08dbd23852da2e",
strip_prefix = "node-v24.5.0-linux-arm64/",
urls = ["https://nodejs.org/dist/v24.5.0/node-v24.5.0-linux-arm64.tar.gz"],
version = "24.5.0",
sha256 = "8956e11dbef5b197d62eb8b5b97a131eb42fbb25347fe0cdc9b62a1c1aa36df5",
strip_prefix = "node-v24.6.0-linux-arm64/",
urls = ["https://nodejs.org/dist/v24.6.0/node-v24.6.0-linux-arm64.tar.gz"],
version = "24.6.0",
architecture = "arm64",
control = "//nodejs:control",
)

node_archive(
name = "nodejs24_ppc64le",
sha256 = "7f45e28aedae5a4077c04fa1934268c9e3620dcfb105624517c2410ca1deb00d",
strip_prefix = "node-v24.5.0-linux-ppc64le/",
urls = ["https://nodejs.org/dist/v24.5.0/node-v24.5.0-linux-ppc64le.tar.gz"],
version = "24.5.0",
sha256 = "fafc88baa9acb9fbf82a0898eb80659918534c0ed6d19a490d86756304c66e67",
strip_prefix = "node-v24.6.0-linux-ppc64le/",
urls = ["https://nodejs.org/dist/v24.6.0/node-v24.6.0-linux-ppc64le.tar.gz"],
version = "24.6.0",
architecture = "ppc64le",
control = "//nodejs:control",
)

node_archive(
name = "nodejs24_s390x",
sha256 = "1d151244f5502ff7e72271e603889d789dec021f0cb28148d90f4a8ce89eaf30",
strip_prefix = "node-v24.5.0-linux-s390x/",
urls = ["https://nodejs.org/dist/v24.5.0/node-v24.5.0-linux-s390x.tar.gz"],
version = "24.5.0",
sha256 = "1cd77586b48b6db1b5248669619c62c785aeca247a4bfaae95fe9820b77a5405",
strip_prefix = "node-v24.6.0-linux-s390x/",
urls = ["https://nodejs.org/dist/v24.6.0/node-v24.6.0-linux-s390x.tar.gz"],
version = "24.6.0",
architecture = "s390x",
control = "//nodejs:control",
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and reduce code duplication, you could refactor the node_archive definitions for Node.js 24. By using a dictionary to store architecture-specific information (like the platform string for the URL and the SHA256 hash) and looping over it, you can eliminate the repeated blocks of code.

This makes it much easier to update versions and checksums in the future, as you'd only need to change them in one place.

    NODE24_VERSION = "24.6.0"
    NODE24_ARCHS = {
        "amd64": ("x64", "352ddbc48b586c11f018ec9b886225117909ea93e05b4a04a6db32f3e63d0281"),
        "arm64": ("arm64", "8956e11dbef5b197d62eb8b5b97a131eb42fbb25347fe0cdc9b62a1c1aa36df5"),
        "ppc64le": ("ppc64le", "fafc88baa9acb9fbf82a0898eb80659918534c0ed6d19a490d86756304c66e67"),
        "s390x": ("s390x", "1cd77586b48b6db1b5248669619c62c785aeca247a4bfaae95fe9820b77a5405"),
    }

    for arch, (platform, sha) in NODE24_ARCHS.items():
        node_archive(
            name = "nodejs24_" + arch,
            sha256 = sha,
            strip_prefix = "node-v{v}-linux-{p}/".format(v=NODE24_VERSION, p=platform),
            urls = ["https://nodejs.org/dist/v{v}/node-v{v}-linux-{p}.tar.gz".format(v=NODE24_VERSION, p=platform)],
            version = NODE24_VERSION,
            architecture = arch,
            control = "//nodejs:control",
        )

@github-actions
Copy link
Contributor

🌳 🔄 Image Check

This pull request has modified the following images:

//nodejs:nodejs24_root_arm64_debian12
//nodejs:nodejs24_debug_root_amd64_debian12
//nodejs:nodejs24_root_amd64_debian12
//nodejs:nodejs24_root_amd64_debian12
//nodejs:nodejs24_root_arm64_debian12
//nodejs:nodejs24_debug_root_amd64_debian12
//nodejs:nodejs24_nonroot_amd64_debian12
//nodejs:nodejs24_nonroot_ppc64le_debian12
//nodejs:nodejs24_debug_nonroot_arm64_debian12
//nodejs:nodejs24_nonroot_amd64_debian12
//nodejs:nodejs24_debug_nonroot_s390x_debian12
//nodejs:nodejs24_nonroot_s390x_debian12
//nodejs:nodejs24_debug_nonroot_amd64_debian12
//nodejs:nodejs24_root_s390x_debian12
//nodejs:nodejs24_debug_root_arm64_debian12
//nodejs:nodejs24_debug_nonroot_arm64_debian12
//nodejs:nodejs24_debug_nonroot_ppc64le_debian12
//nodejs:nodejs24_root_ppc64le_debian12
//nodejs:nodejs24_debug_root_ppc64le_debian12
//nodejs:nodejs24_debug_root_arm64_debian12
//nodejs:nodejs24_nonroot_arm64_debian12
//nodejs:nodejs24_nonroot_s390x_debian12
//nodejs:nodejs24_nonroot_arm64_debian12
//nodejs:nodejs24_root_s390x_debian12
//nodejs:nodejs24_debug_root_s390x_debian12
//nodejs:nodejs24_debug_nonroot_s390x_debian12
//nodejs:nodejs24_debug_nonroot_ppc64le_debian12
//nodejs:nodejs24_debug_root_ppc64le_debian12
//nodejs:nodejs24_debug_root_s390x_debian12
//nodejs:nodejs24_root_ppc64le_debian12
//nodejs:nodejs24_debug_nonroot_amd64_debian12
//nodejs:nodejs24_nonroot_ppc64le_debian12

You can check the details in the report here

@loosebazooka loosebazooka merged commit 8dc3180 into main Aug 15, 2025
11 checks passed
@loosebazooka loosebazooka deleted the update-node-archives branch August 15, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants