Skip to content

Bumping node archives to latest stable versions #1843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loosebazooka merged 1 commit into from
Aug 15, 2025
Merged

Bumping node archives to latest stable versions #1843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions MODULE.bazel.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion nodejs/testdata/nodejs24.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ commandTests:
- name: nodejs
command: "/nodejs/bin/node"
args: ["--version"]
expectedOutput: ["v24.5.0"]
expectedOutput: ["v24.6.0"]
32 changes: 16 additions & 16 deletions private/extensions/node.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,40 +199,40 @@ def _node_impl(module_ctx):

node_archive(
name = "nodejs24_amd64",
sha256 = "369f2a3668dde7e324697040fafdcf442fd198b8c102317145417b3c83a9794a",
strip_prefix = "node-v24.5.0-linux-x64/",
urls = ["https://nodejs.org/dist/v24.5.0/node-v24.5.0-linux-x64.tar.gz"],
version = "24.5.0",
sha256 = "352ddbc48b586c11f018ec9b886225117909ea93e05b4a04a6db32f3e63d0281",
strip_prefix = "node-v24.6.0-linux-x64/",
urls = ["https://nodejs.org/dist/v24.6.0/node-v24.6.0-linux-x64.tar.gz"],
version = "24.6.0",
architecture = "amd64",
control = "//nodejs:control",
)

node_archive(
name = "nodejs24_arm64",
sha256 = "c643c118d907c8db42a677a12789eb5d55ad6de4b8e2c11bab08dbd23852da2e",
strip_prefix = "node-v24.5.0-linux-arm64/",
urls = ["https://nodejs.org/dist/v24.5.0/node-v24.5.0-linux-arm64.tar.gz"],
version = "24.5.0",
sha256 = "8956e11dbef5b197d62eb8b5b97a131eb42fbb25347fe0cdc9b62a1c1aa36df5",
strip_prefix = "node-v24.6.0-linux-arm64/",
urls = ["https://nodejs.org/dist/v24.6.0/node-v24.6.0-linux-arm64.tar.gz"],
version = "24.6.0",
architecture = "arm64",
control = "//nodejs:control",
)

node_archive(
name = "nodejs24_ppc64le",
sha256 = "7f45e28aedae5a4077c04fa1934268c9e3620dcfb105624517c2410ca1deb00d",
strip_prefix = "node-v24.5.0-linux-ppc64le/",
urls = ["https://nodejs.org/dist/v24.5.0/node-v24.5.0-linux-ppc64le.tar.gz"],
version = "24.5.0",
sha256 = "fafc88baa9acb9fbf82a0898eb80659918534c0ed6d19a490d86756304c66e67",
strip_prefix = "node-v24.6.0-linux-ppc64le/",
urls = ["https://nodejs.org/dist/v24.6.0/node-v24.6.0-linux-ppc64le.tar.gz"],
version = "24.6.0",
architecture = "ppc64le",
control = "//nodejs:control",
)

node_archive(
name = "nodejs24_s390x",
sha256 = "1d151244f5502ff7e72271e603889d789dec021f0cb28148d90f4a8ce89eaf30",
strip_prefix = "node-v24.5.0-linux-s390x/",
urls = ["https://nodejs.org/dist/v24.5.0/node-v24.5.0-linux-s390x.tar.gz"],
version = "24.5.0",
sha256 = "1cd77586b48b6db1b5248669619c62c785aeca247a4bfaae95fe9820b77a5405",
strip_prefix = "node-v24.6.0-linux-s390x/",
urls = ["https://nodejs.org/dist/v24.6.0/node-v24.6.0-linux-s390x.tar.gz"],
version = "24.6.0",
architecture = "s390x",
control = "//nodejs:control",
)
Comment on lines 200 to 238
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and reduce code duplication, you could refactor the node_archive definitions for Node.js 24. By using a dictionary to store architecture-specific information (like the platform string for the URL and the SHA256 hash) and looping over it, you can eliminate the repeated blocks of code.

This makes it much easier to update versions and checksums in the future, as you'd only need to change them in one place.

    NODE24_VERSION = "24.6.0"
    NODE24_ARCHS = {
        "amd64": ("x64", "352ddbc48b586c11f018ec9b886225117909ea93e05b4a04a6db32f3e63d0281"),
        "arm64": ("arm64", "8956e11dbef5b197d62eb8b5b97a131eb42fbb25347fe0cdc9b62a1c1aa36df5"),
        "ppc64le": ("ppc64le", "fafc88baa9acb9fbf82a0898eb80659918534c0ed6d19a490d86756304c66e67"),
        "s390x": ("s390x", "1cd77586b48b6db1b5248669619c62c785aeca247a4bfaae95fe9820b77a5405"),
    }

    for arch, (platform, sha) in NODE24_ARCHS.items():
        node_archive(
            name = "nodejs24_" + arch,
            sha256 = sha,
            strip_prefix = "node-v{v}-linux-{p}/".format(v=NODE24_VERSION, p=platform),
            urls = ["https://nodejs.org/dist/v{v}/node-v{v}-linux-{p}.tar.gz".format(v=NODE24_VERSION, p=platform)],
            version = NODE24_VERSION,
            architecture = arch,
            control = "//nodejs:control",
        )

Expand Down
Loading