Bumping temurin archives to latest stable versions#1847
Bumping temurin archives to latest stable versions#1847distroless-bot wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: Distroless Bot <distroless-bot@google.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @distroless-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request, titled as a version bump, primarily focuses on a minor formatting adjustment within the private/repos/java.MODULE.bazel file. It reorders the architecture and plain_version parameters in the java.archive definitions for various Temurin 21 JRE and JDK distributions. It's important to note that the actual Temurin versions and their corresponding SHA256 checksums have not been updated in this change; only the order of these specific attributes within the Bazel configuration has been modified.
Highlights
- Parameter Reordering: The
architectureandplain_versionattributes within thejava.archivecalls for all Temurin 21 JRE and JDK definitions (amd64, arm64, ppc64le) have been reordered. They now appear after theversionattribute. - No Version or SHA Update: Despite the pull request title, the
versionstrings (e.g., "21.0.8+9") andsha256checksums for the Temurin 21 archives remain unchanged in this update. The change is purely a reordering of parameters.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request from the Distroless Bot reformats the java.archive definitions in private/repos/java.MODULE.bazel by reordering attributes for consistency. Although the title suggests a version bump, the Java versions and checksums remain unchanged as they are already up-to-date. The change is purely stylistic. I have added one suggestion to improve the maintainability of the generated Bazel file by reducing code duplication.
| java.archive( | ||
| name = "temurin21_jre_amd64", | ||
| architecture = "amd64", | ||
| plain_version = "21.0.8", | ||
| sha256 = "968c283e104059dae86ea1d670672a80170f27a39529d815843ec9c1f0fa2a03", | ||
| strip_prefix = "jdk-21.0.8+9-jre", | ||
| urls = ["https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21.0.8%2B9/OpenJDK21U-jre_x64_linux_hotspot_21.0.8_9.tar.gz"], | ||
| version = "21.0.8+9", | ||
| plain_version = "21.0.8", | ||
| architecture = "amd64", | ||
| ) | ||
| java.archive( | ||
| name = "temurin21_jdk_amd64", | ||
| architecture = "amd64", | ||
| plain_version = "21.0.8", | ||
| sha256 = "f2dc5418092c43003db8f9005c4a286e1c0104fea96ccdd49e8ebd037cac9219", | ||
| strip_prefix = "jdk-21.0.8+9", | ||
| urls = ["https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21.0.8%2B9/OpenJDK21U-jdk_x64_linux_hotspot_21.0.8_9.tar.gz"], | ||
| version = "21.0.8+9", | ||
| plain_version = "21.0.8", | ||
| architecture = "amd64", | ||
| ) | ||
| java.archive( | ||
| name = "temurin21_jre_arm64", | ||
| architecture = "arm64", | ||
| plain_version = "21.0.8", | ||
| sha256 = "f54f6e2a907c4aef95ce6d7388474c6d5d87ae87899dd309561672bcfda9121e", | ||
| strip_prefix = "jdk-21.0.8+9-jre", | ||
| urls = ["https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21.0.8%2B9/OpenJDK21U-jre_aarch64_linux_hotspot_21.0.8_9.tar.gz"], | ||
| version = "21.0.8+9", | ||
| plain_version = "21.0.8", | ||
| architecture = "arm64", | ||
| ) | ||
| java.archive( | ||
| name = "temurin21_jdk_arm64", | ||
| architecture = "arm64", | ||
| plain_version = "21.0.8", | ||
| sha256 = "e5c41a1ab0865ea5de9b4529bf8526005f1d4593090845387d14fe450ce39c33", | ||
| strip_prefix = "jdk-21.0.8+9", | ||
| urls = ["https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21.0.8%2B9/OpenJDK21U-jdk_aarch64_linux_hotspot_21.0.8_9.tar.gz"], | ||
| version = "21.0.8+9", | ||
| plain_version = "21.0.8", | ||
| architecture = "arm64", | ||
| ) | ||
| java.archive( | ||
| name = "temurin21_jre_ppc64le", | ||
| architecture = "ppc64le", | ||
| plain_version = "21.0.8", | ||
| sha256 = "12c351c7a6906ca4ddd3f158cbd9ebf2733bab2dc432dc3f9d5685476b16b7bc", | ||
| strip_prefix = "jdk-21.0.8+9-jre", | ||
| urls = ["https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21.0.8%2B9/OpenJDK21U-jre_ppc64le_linux_hotspot_21.0.8_9.tar.gz"], | ||
| version = "21.0.8+9", | ||
| plain_version = "21.0.8", | ||
| architecture = "ppc64le", | ||
| ) | ||
| java.archive( | ||
| name = "temurin21_jdk_ppc64le", | ||
| architecture = "ppc64le", | ||
| plain_version = "21.0.8", | ||
| sha256 = "a24e869b8e563fd7b9f7776f6686ca5d737c8d1c3c33c9b72836935709b44a34", | ||
| strip_prefix = "jdk-21.0.8+9", | ||
| urls = ["https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21.0.8%2B9/OpenJDK21U-jdk_ppc64le_linux_hotspot_21.0.8_9.tar.gz"], | ||
| version = "21.0.8+9", | ||
| plain_version = "21.0.8", | ||
| architecture = "ppc64le", | ||
| ) |
There was a problem hiding this comment.
To improve maintainability and reduce redundancy, consider defining the repeated version strings ("21.0.8+9" and "21.0.8") as constants at the top of the file. These constants can then be referenced in each java.archive block.
This change would need to be implemented in the script that generates this file, scripts/update_java_archives.sh.
For example:
_VERSION = "21.0.8+9"
_PLAIN_VERSION = "21.0.8"
java.archive(
name = "temurin21_jre_amd64",
# ... other attributes
version = _VERSION,
plain_version = _PLAIN_VERSION,
architecture = "amd64",
)
# ...
|
🌳 🔄 Image Check |
|
oh this isn't an update, we changed the order of some stuff, I think we need to update the generator. |
2 participants
Signed-off-by: Distroless Bot distroless-bot@google.com