Skip to content

Bumping temurin archives to latest stable versions #1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
distroless-bot wants to merge 1 commit into from
Closed

Bumping temurin archives to latest stable versions #1847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MODULE.bazel.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 12 additions & 12 deletions private/repos/java.MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,56 +5,56 @@
java = use_extension("//private/extensions:java.bzl", "java")
java.archive(
name = "temurin21_jre_amd64",
architecture = "amd64",
plain_version = "21.0.8",
sha256 = "968c283e104059dae86ea1d670672a80170f27a39529d815843ec9c1f0fa2a03",
strip_prefix = "jdk-21.0.8+9-jre",
urls = ["https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21.0.8%2B9/OpenJDK21U-jre_x64_linux_hotspot_21.0.8_9.tar.gz"],
version = "21.0.8+9",
plain_version = "21.0.8",
architecture = "amd64",
)
java.archive(
name = "temurin21_jdk_amd64",
architecture = "amd64",
plain_version = "21.0.8",
sha256 = "f2dc5418092c43003db8f9005c4a286e1c0104fea96ccdd49e8ebd037cac9219",
strip_prefix = "jdk-21.0.8+9",
urls = ["https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21.0.8%2B9/OpenJDK21U-jdk_x64_linux_hotspot_21.0.8_9.tar.gz"],
version = "21.0.8+9",
plain_version = "21.0.8",
architecture = "amd64",
)
java.archive(
name = "temurin21_jre_arm64",
architecture = "arm64",
plain_version = "21.0.8",
sha256 = "f54f6e2a907c4aef95ce6d7388474c6d5d87ae87899dd309561672bcfda9121e",
strip_prefix = "jdk-21.0.8+9-jre",
urls = ["https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21.0.8%2B9/OpenJDK21U-jre_aarch64_linux_hotspot_21.0.8_9.tar.gz"],
version = "21.0.8+9",
plain_version = "21.0.8",
architecture = "arm64",
)
java.archive(
name = "temurin21_jdk_arm64",
architecture = "arm64",
plain_version = "21.0.8",
sha256 = "e5c41a1ab0865ea5de9b4529bf8526005f1d4593090845387d14fe450ce39c33",
strip_prefix = "jdk-21.0.8+9",
urls = ["https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21.0.8%2B9/OpenJDK21U-jdk_aarch64_linux_hotspot_21.0.8_9.tar.gz"],
version = "21.0.8+9",
plain_version = "21.0.8",
architecture = "arm64",
)
java.archive(
name = "temurin21_jre_ppc64le",
architecture = "ppc64le",
plain_version = "21.0.8",
sha256 = "12c351c7a6906ca4ddd3f158cbd9ebf2733bab2dc432dc3f9d5685476b16b7bc",
strip_prefix = "jdk-21.0.8+9-jre",
urls = ["https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21.0.8%2B9/OpenJDK21U-jre_ppc64le_linux_hotspot_21.0.8_9.tar.gz"],
version = "21.0.8+9",
plain_version = "21.0.8",
architecture = "ppc64le",
)
java.archive(
name = "temurin21_jdk_ppc64le",
architecture = "ppc64le",
plain_version = "21.0.8",
sha256 = "a24e869b8e563fd7b9f7776f6686ca5d737c8d1c3c33c9b72836935709b44a34",
strip_prefix = "jdk-21.0.8+9",
urls = ["https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21.0.8%2B9/OpenJDK21U-jdk_ppc64le_linux_hotspot_21.0.8_9.tar.gz"],
version = "21.0.8+9",
plain_version = "21.0.8",
architecture = "ppc64le",
)
Comment on lines 6 to 59
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and reduce redundancy, consider defining the repeated version strings ("21.0.8+9" and "21.0.8") as constants at the top of the file. These constants can then be referenced in each java.archive block.

This change would need to be implemented in the script that generates this file, scripts/update_java_archives.sh.

For example:

_VERSION = "21.0.8+9"
_PLAIN_VERSION = "21.0.8"

java.archive(
    name = "temurin21_jre_amd64",
    # ... other attributes
    version = _VERSION,
    plain_version = _PLAIN_VERSION,
    architecture = "amd64",
)
# ...

use_repo(java, "java_versions", "temurin21_jdk_amd64", "temurin21_jdk_arm64", "temurin21_jdk_ppc64le", "temurin21_jre_amd64", "temurin21_jre_arm64", "temurin21_jre_ppc64le")
Loading