Skip to content

Conversation

@mattsanta
Copy link
Contributor

Upgrade golang version.

@mattsanta mattsanta requested a review from a team as a code owner January 6, 2026 21:27
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @mattsanta, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a routine maintenance update by upgrading the Go language version used in the project. This ensures that the codebase benefits from the latest improvements, bug fixes, and security patches available in Go 1.25.5, maintaining compatibility and leveraging updated language features.

Highlights

  • Go Version Upgrade: The project's Go language version has been updated from 1.25.4 to 1.25.5 across the build dependencies and module definition.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (6)
    • .github/workflows/integration-linux.yml
    • .github/workflows/linters-checks.yml
    • .github/workflows/unit-tests-darwin.yml
    • .github/workflows/unit-tests-linux.yml
    • .github/workflows/unit-tests-windows.yml
    • .github/workflows/verify-examples.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the Go version from 1.25.4 to 1.25.5. The changes in go.mod and deploy/skaffold/Dockerfile.deps are correct and consistent. However, the go.sum file has not been updated to reflect the new Go toolchain version. It is necessary to run go mod tidy and commit the changes to go.sum to ensure build reproducibility. I've added a comment with details.

module github.com/GoogleContainerTools/skaffold/v2

go 1.25.4
go 1.25.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

After updating the Go version in go.mod, it's important to run go mod tidy to update the go.sum file accordingly. This ensures that the checksums for the toolchain and dependencies are updated, which is crucial for reproducible builds. Since Go 1.21, go mod tidy adds a go line to go.sum with the toolchain version, which is missing here. Please run go mod tidy and commit the resulting changes to go.sum.

@menahyouyeah menahyouyeah added the kokoro:force-run forces a kokoro re-run on a PR label Jan 7, 2026
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Jan 7, 2026
@mattsanta mattsanta added the kokoro:force-run forces a kokoro re-run on a PR label Jan 7, 2026
@mattsanta mattsanta added kokoro:force-run forces a kokoro re-run on a PR and removed kokoro:force-run forces a kokoro re-run on a PR labels Jan 7, 2026
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Jan 7, 2026
@mattsanta mattsanta merged commit cddeba4 into GoogleContainerTools:main Jan 7, 2026
12 checks passed
@mattsanta mattsanta deleted the go branch January 7, 2026 16:29
mattsanta added a commit to mattsanta/skaffold that referenced this pull request Jan 7, 2026
@mattsanta mattsanta mentioned this pull request Jan 7, 2026
mattsanta added a commit that referenced this pull request Jan 7, 2026
* chore: bump golang.org/x/crypto from 0.43.0 to 0.45.0 (#9917)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.43.0 to 0.45.0.
- [Commits](golang/crypto@v0.43.0...v0.45.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-version: 0.45.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: bump the github-actions group across 1 directory with 3 updates (#9934)

Bumps the github-actions group with 3 updates in the / directory: [actions/checkout](https://github.com/actions/checkout), [actions/cache](https://github.com/actions/cache) and [actions/upload-artifact](https://github.com/actions/upload-artifact).


Updates `actions/checkout` from 5 to 6
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v5...v6)

Updates `actions/cache` from 4 to 5
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v4...v5)

Updates `actions/upload-artifact` from 5 to 6
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v5...v6)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
- dependency-name: actions/cache
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
- dependency-name: actions/upload-artifact
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ci: disabling kaniko integration tests due to kaniko service account permissions issue and fix github workflow (#9943)

disabling kaniko integration tests due to kaniko service accountpermissioning issue and fix github workflow

Co-authored-by: Darien-Lin <[email protected]>

* chore: upgrade golang to 1.25.5 (#9944)

* Upgrade github.com/google/ko to v0.18.1 (#9939)

* Upgrade github.com/google/ko to v0.18.1

* Upgrade github.com/google/ko to v0.18.1 continue

* fix a issue in docker/auth.go

* fix go version issue in test

* revert go version changes in test

* update docker cli vendor files

* Trigger GitHub Actions

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Darien Lin <[email protected]>
Co-authored-by: Darien-Lin <[email protected]>
Co-authored-by: Chris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants