Finish building Postgres support#133
Merged
djmitche merged 2 commits intoGothenburgBitFactory:mainfrom Jul 30, 2025
Merged
Conversation
This includes: - Building a Docker image for Postgres as well as SQLite - Fuller instructions for usage of the package, including the Postgres builds. A few related things changed here: - `.env` is not used anymore -- the defaults in the Dockerfiles are sufficient - The Rust version in the Dockerfiles is increased to match the MSRV, and with it the Alpine version bumped to one built with that Rust version. - Cargo dependencies on native-tls and openssl updated to include only the `vendored` feature, so as not to require a system openssl installation. - Two GitHub jobs are set up, to build the two different Docker images - The documentation incorrectly suggested using `DELETE .. CASCADE` to delete clients. This syntax does not exist, as the cascading delete is configured in the schema.
ryneeverett
approved these changes
Jul 29, 2025
.github/workflows/docker.yml
Outdated
Comment on lines
+48
to
+49
| - name: Load .env file | ||
| uses: xom9ikk/dotenv@v2 |
Contributor
There was a problem hiding this comment.
Can this be deleted since you've deleted the .env file?
Collaborator
Author
There was a problem hiding this comment.
Yes, and the build-args too!
docs/src/usage.md
Outdated
| - If you only need a place to sync your tasks, using cloud storage may be | ||
| cheaper and easier than running taskchampion-sync-server. See | ||
| [task-sync(5)](http://taskwarrior.org/docs/man/task-sync.5/) for details on | ||
| confusing cloud storage. |
Contributor
There was a problem hiding this comment.
The task-sync docs aren't that bad. :)
Suggested change
| confusing cloud storage. | |
| cloud storage. |
Collaborator
Author
There was a problem hiding this comment.
What subliminal short-circuit made me type that?!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes:
A few related things changed here:
.envis not used anymore -- the defaults in the Dockerfiles are sufficientvendoredfeature, so as not to require a system openssl installation.DELETE .. CASCADEto delete clients. This syntax does not exist, as the cascading delete is configured in the schema.