Set Main-Class attr for KMP 1.9.0 or above
#1410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goooler
force-pushed
the
g/20250423/test-older-kmp
branch
from
09e15dc to
3e56d26
Compare
This reverts commit 3e56d26.
Goooler
changed the title
Main-Class attr for KMP 1.9.0 or above
There was a problem hiding this comment.
Pull Request Overview
This PR updates the minimum supported KMP version for setting the Main-Class attribute to 1.9.0. The changes include updating the version check in the plugin code, removing the outdated version reference in the documentation, and adding a corresponding changelog entry.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowKmpPlugin.kt | Updated version check condition to align with KMP 1.9.0+ requirements. |
| docs/kotlin-plugins/README.md | Removed outdated version reference and updated code snippet comments. |
| docs/changes/README.md | Added changelog entry for setting the Main-Class attribute for KMP 1.9.0 or above. |
Comments suppressed due to low confidence (1)
docs/kotlin-plugins/README.md:125
- Kotlin string literals require double quotes. Please update 'myapp.MainKt' to "myapp.MainKt" to ensure correct syntax in the code snippet.
it.mainClass.set('myapp.MainKt')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/JetBrains/kotlin/releases/tag/v1.9.0
https://youtrack.jetbrains.com/issue/KT-58661
JetBrains/kotlin@e0389a0
Follow up #1337.