Skip to content

Set Main-Class attr for KMP 1.9.0 or above #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 23, 2025
Merged

Set Main-Class attr for KMP 1.9.0 or above #1410

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
778a3e9
Test for KMP 2.0.21-RC
Goooler Apr 23, 2025
90ed2df
Merge remote-tracking branch 'origin/main' into g/20250423/test-older…
Goooler Apr 23, 2025
c2108f7
Use mainClass added from KGP 1.9.0
Goooler Apr 23, 2025
3e56d26
Test for KMP 1.9.0
Goooler Apr 23, 2025
e9d4fc5
Revert "Test for KMP 1.9.0"
Goooler Apr 23, 2025
747136d
Update docs
Goooler Apr 23, 2025
3e5c564
Merge branch 'main' into g/20250423/test-older-kmp
Goooler Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/changes/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## [Unreleased](https://github.com/GradleUp/shadow/compare/9.0.0-beta12...HEAD) - 2025-xx-xx

**Changed**

- Set `Main-Class` attr for KMP 1.9.0 or above. ([#1410](https://github.com/GradleUp/shadow/pull/1410))

**Fixed**

- Avoid creating jvm targets eagerly for KMP. ([#1378](https://github.com/GradleUp/shadow/pull/1378))
Expand Down Expand Up @@ -621,7 +625,7 @@
- [Sergey Tselovalnikov](https://github.com/SerCeMan) - Upgrade to ASM 6.2.1 to support Java 11
- [Chris Cowan](https://github.com/Macil) - Add support for `shadowJar.preserveFileTimestamps` property.
See [Jar.preserveFileTimestamps](https://docs.gradle.org/current/dsl/org.gradle.api.tasks.bundling.Jar.html#org.gradle.api.tasks.bundling.Jar:preserveFileTimestamps)
- [Paul N. Baker](https://github.com/niko-dunixi) - Add `Log4j2PluginsCacheFileTransformer` to process Log4j DAT files

Check failure on line 628 in docs/changes/README.md

View workflow job for this annotation

GitHub Actions / Linkspector

[linkspector] docs/changes/README.md#L628 

Cannot reach https://github.com/niko-dunixi Status: 404
Raw output 
message:"Cannot reach https://github.com/niko-dunixi Status: 404" location:{path:"docs/changes/README.md" range:{start:{line:628 column:3} end:{line:628 column:50}}} severity:ERROR source:{name:"linkspector" url:"https://github.com/UmbrellaDocs/linkspector"}
during merge.
- [Felipe Lima](https://github.com/felipecsl) - Fix the long standing "No property `mainClassName`" issue.
- [debanne](https://github.com/debanne) - Implement JAR minimization actions. This will attempt to exclude unused
Expand Down
4 changes: 2 additions & 2 deletions docs/kotlin-plugins/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ automatically configure additional tasks for bundling the shadowed JAR for its `
kotlin {
@Suppress("OPT_IN_USAGE")
jvm().mainRun {
// Optionally, set the main class for `runJvm`, it's available from Kotlin 2.1.0
// Optionally, set the main class for `runJvm`.
mainClass = "myapp.MainKt"
}
sourceSets {
Expand Down Expand Up @@ -121,7 +121,7 @@ automatically configure additional tasks for bundling the shadowed JAR for its `

kotlin {
jvm().mainRun {
// Optionally, set the main class for `runJvm`, it's available from Kotlin 2.1.0
// Optionally, set the main class for `runJvm`.
it.mainClass.set('myapp.MainKt')
}
sourceSets {
Expand Down
2 changes: 1 addition & 1 deletion src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowKmpPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public abstract class ShadowKmpPlugin : Plugin<Project> {
},
)

if (!isAtLeastKgpVersion(2, 1, 0)) return@registerShadowJarCommon
if (!isAtLeastKgpVersion(1, 9, 0)) return@registerShadowJarCommon

@OptIn(ExperimentalKotlinGradlePluginApi::class)
target.mainRun {
Expand Down
Loading