Skip to content

Conversation

@GregHib
Copy link
Owner

@GregHib GregHib commented Nov 28, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

Qodana Community for JVM

1 new problem were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 11.44068% with 209 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.08%. Comparing base (30a490a) to head (2ee3a9f).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...nt/entity/player/command/PlayerUpdatingCommands.kt 2.85% 34 Missing ⚠️
...tlin/content/entity/player/command/MetaCommands.kt 0.00% 30 Missing ⚠️
...ntent/entity/player/command/NPCUpdatingCommands.kt 0.00% 23 Missing ⚠️
.../content/entity/player/command/VariableCommands.kt 5.26% 18 Missing ⚠️
...ntent/entity/player/command/PathFindingCommands.kt 5.88% 16 Missing ⚠️
...content/entity/player/command/InterfaceCommands.kt 0.00% 13 Missing ⚠️
...lin/content/entity/player/command/SoundCommands.kt 0.00% 13 Missing ⚠️
...in/content/entity/player/command/CameraCommands.kt 0.00% 10 Missing ⚠️
.../content/entity/player/command/TeleportCommands.kt 0.00% 10 Missing ⚠️
...tlin/content/entity/player/command/ZoneCommands.kt 0.00% 6 Missing ⚠️
... and 22 more
Additional details and impacted files
Files with missing lines Coverage Δ
...tlin/world/gregs/voidps/engine/entity/Operation.kt 75.86% <ø> (-0.28%) ⬇️
game/src/main/kotlin/GameTick.kt 77.58% <100.00%> (+0.80%) ⬆️
...tivity/penguin_hide_and_seek/PenguinHideAndSeek.kt 69.04% <100.00%> (ø)
...me/src/main/kotlin/content/entity/combat/Combat.kt 66.98% <100.00%> (ø)
...in/content/entity/player/command/PlayerCommands.kt 28.64% <100.00%> (ø)
...lin/content/entity/player/command/SkillCommands.kt 50.00% <100.00%> (+1.28%) ⬆️
...in/kotlin/content/skill/woodcutting/Woodcutting.kt 54.44% <100.00%> (+7.77%) ⬆️
...e/client/instruction/handle/ObjectOptionHandler.kt 0.00% <0.00%> (ø)
...cter/mode/interact/InterfaceOnFloorItemInteract.kt 93.33% <0.00%> (-6.67%) ⬇️
.../character/mode/interact/InterfaceOnNPCInteract.kt 92.85% <0.00%> (-7.15%) ⬇️
... and 29 more

... and 12 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #807      +/-   ##
============================================
- Coverage     37.18%   37.08%   -0.10%     
- Complexity     7053     7079      +26     
============================================
  Files          1455     1458       +3     
  Lines         55929    56223     +294     
  Branches      14007    14082      +75     
============================================
+ Hits          20798    20853      +55     
- Misses        30495    30732     +237     
- Partials       4636     4638       +2     
Components Coverage Δ
Content 33.93% <10.00%> (-0.12%) ⬇️
Engine 44.80% <23.07%> (-0.06%) ⬇️
Network 60.36% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GregHib GregHib merged commit 3a8b468 into main Nov 28, 2025
5 checks passed
@GregHib GregHib deleted the bug-fixes branch November 28, 2025 16:14
Ilwyd pushed a commit to Ilwyd/void that referenced this pull request Dec 22, 2025
* Fix level up messages cancelling skills GregHib#806

* Fix broken chinchompa gfx closes GregHib#802

* Fix npcs attack style closes GregHib#803

* Add an item add or drop helper

* Add interact debug

* Some random keywords

* Tidy up audit log outputs

* Remove duplicate map definition loading in tests

* Fix canoe tests

* Allow script access in WorldTest

* Remove println

* Change set_level to level command

* Fix ranged ammo removal cancelling level up dialogues closes GregHib#806

* Formatting

* Fix arrows in range test

* Use transformed def in tests

* Formatting

* Make command handlers extend Player
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants