Skip to content

More bug fixes and qol #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GregHib merged 18 commits into from
Nov 28, 2025

Make command handlers extend Player

2ee3a9f
Select commit
Loading
Failed to load commit list.
Merged

More bug fixes and qol #807

Make command handlers extend Player
2ee3a9f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 28, 2025 in 0s

37.08% (-0.10%) compared to 30a490a

View this Pull Request on Codecov

37.08% (-0.10%) compared to 30a490a

Details

Codecov Report

❌ Patch coverage is 11.44068% with 209 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.08%. Comparing base (30a490a) to head (2ee3a9f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nt/entity/player/command/PlayerUpdatingCommands.kt 2.85% 34 Missing ⚠️
...tlin/content/entity/player/command/MetaCommands.kt 0.00% 30 Missing ⚠️
...ntent/entity/player/command/NPCUpdatingCommands.kt 0.00% 23 Missing ⚠️
.../content/entity/player/command/VariableCommands.kt 5.26% 18 Missing ⚠️
...ntent/entity/player/command/PathFindingCommands.kt 5.88% 16 Missing ⚠️
...content/entity/player/command/InterfaceCommands.kt 0.00% 13 Missing ⚠️
...lin/content/entity/player/command/SoundCommands.kt 0.00% 13 Missing ⚠️
...in/content/entity/player/command/CameraCommands.kt 0.00% 10 Missing ⚠️
.../content/entity/player/command/TeleportCommands.kt 0.00% 10 Missing ⚠️
...tlin/content/entity/player/command/ZoneCommands.kt 0.00% 6 Missing ⚠️
... and 22 more
Additional details and impacted files
Files with missing lines Coverage Δ
...tlin/world/gregs/voidps/engine/entity/Operation.kt 75.86% <ø> (-0.28%) ⬇️
game/src/main/kotlin/GameTick.kt 77.58% <100.00%> (+0.80%) ⬆️
...tivity/penguin_hide_and_seek/PenguinHideAndSeek.kt 69.04% <100.00%> (ø)
...me/src/main/kotlin/content/entity/combat/Combat.kt 66.98% <100.00%> (ø)
...in/content/entity/player/command/PlayerCommands.kt 28.64% <100.00%> (ø)
...lin/content/entity/player/command/SkillCommands.kt 50.00% <100.00%> (+1.28%) ⬆️
...in/kotlin/content/skill/woodcutting/Woodcutting.kt 54.44% <100.00%> (+7.77%) ⬆️
...e/client/instruction/handle/ObjectOptionHandler.kt 0.00% <0.00%> (ø)
...cter/mode/interact/InterfaceOnFloorItemInteract.kt 93.33% <0.00%> (-6.67%) ⬇️
.../character/mode/interact/InterfaceOnNPCInteract.kt 92.85% <0.00%> (-7.15%) ⬇️
... and 29 more

... and 12 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #807      +/-   ##
============================================
- Coverage     37.18%   37.08%   -0.10%     
- Complexity     7053     7079      +26     
============================================
  Files          1455     1458       +3     
  Lines         55929    56223     +294     
  Branches      14007    14082      +75     
============================================
+ Hits          20798    20853      +55     
- Misses        30495    30732     +237     
- Partials       4636     4638       +2
Components Coverage Δ
Content 33.93% <10.00%> (-0.12%) ⬇️
Engine 44.80% <23.07%> (-0.06%) ⬇️
Network 60.36% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov