Fix Packet Data Memory Leak #2823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruberu
reviewed
Jun 18, 2025
src/main/java/gregtech/api/metatileentity/SyncedTileEntityBase.java
Outdated
Show resolved
Hide resolved
only clear updates when not empty
bruberu
approved these changes
Jun 18, 2025
bruberu
approved these changes
Jun 29, 2025
Zorbatron
pushed a commit
that referenced
this pull request
Jul 4, 2025
MCTian-mi
added a commit
to SymmetricDevs/Susy-Core
that referenced
this pull request
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes a server-side issue where packet data will build up when in chunks outside of render distance but force-loaded (with FTB utils, etc).
Implementation Details
checks the player chunk map if it contains the chunk pos of the updating TE
checks the packet size to reduce hash lookups
clears discriminator data in packet data list as well as byte data and size
Outcome
packets no longer eat your ram