Fix Memory Leak Fix (#2823) #2839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghzdude
added
type: bug
Zorbatron
approved these changes
Jul 4, 2025
Zorbatron
added
type: bug
Member
|
I removed and re-added the bug label because the label check was stuck |
MCTian-mi
added a commit
to SymmetricDevs/Susy-Core
that referenced
this pull request
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes a small oversight introduced in #2823 where small data packets would never be sent to the client because
canNotifyWorld()defaults to false.Implementation Details
return
trueinstead offalsereplace literal
10with a named constantOutcome
machines actually update the client