Skip to content

Fix Memory Leak Fix (#2823) #2839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zorbatron merged 2 commits into from
Jul 4, 2025
+4 −2
Merged

Fix Memory Leak Fix (#2823) #2839

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8435452
default to true when checking notify world
ghzdude Jul 3, 2025
115f4c6
replace literal with a named constant
ghzdude Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/main/java/gregtech/api/metatileentity/SyncedTileEntityBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@

public abstract class SyncedTileEntityBase extends BlockStateTileEntity implements ISyncedTileEntity {

public static final int SIZE_THRESHOLD = 10;
private final PacketDataList updates = new PacketDataList();

public @Nullable TileEntity getNeighbor(EnumFacing facing) {
Expand Down Expand Up @@ -65,7 +66,7 @@ private void notifyWorld() {

private boolean canNotifyWorld() {
// short circuit with packet size to avoid too many hash lookups and instanceof casts
if (updates.size() > 10 && getWorld() instanceof WorldServer server) {
if (updates.size() > SIZE_THRESHOLD && getWorld() instanceof WorldServer server) {
int x = getPos().getX() >> 4;
int z = getPos().getZ() >> 4;
if (server.getPlayerChunkMap().contains(x, z)) {
Expand All @@ -76,7 +77,8 @@ private boolean canNotifyWorld() {
return false;
}
}
return false;
// assume we can send data regardless
return true;
}

@Override
Expand Down
Loading