Skip to content

Conversation

@kemingy
Copy link

@kemingy kemingy commented Aug 3, 2025

  • cargo clippy --fix
  • ignore the large_enum_variant as upstream

Signed-off-by: Keming <[email protected]>
@kemingy kemingy marked this pull request as draft August 3, 2025 13:23
Signed-off-by: Keming <[email protected]>
@kemingy kemingy marked this pull request as ready for review August 3, 2025 13:45
@kemingy kemingy changed the title fix: lint and test fix: make cargo clippy happy Aug 3, 2025
Copy link
Member

@sunng87 sunng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sunng87 sunng87 merged commit 2edba96 into GreptimeTeam:v0.54.x Aug 3, 2025
3 of 9 checks passed
@kemingy kemingy deleted the lint branch August 3, 2025 14:56
MichaelScofield added a commit that referenced this pull request Aug 5, 2025
fix cargo fmt
Merge branch 'v0.54.x' into v0.54.x
Merge pull request #20 from kemingy/calc_overflow
fix lint
Merge branch 'v0.54.x' into v0.54.x
Merge pull request #19 from kemingy/lint
add test for statement convertion
fix: overflow in the calculation expr
fix the test in another pr
fix overflow
fix: lint and test
fix: add recursive protection to Convert
MichaelScofield added a commit that referenced this pull request Sep 29, 2025
fix cargo fmt
Merge branch 'v0.54.x' into v0.54.x
Merge pull request #20 from kemingy/calc_overflow
fix lint
Merge branch 'v0.54.x' into v0.54.x
Merge pull request #19 from kemingy/lint
add test for statement convertion
fix: overflow in the calculation expr
fix the test in another pr
fix overflow
fix: lint and test
fix: add recursive protection to Convert
MichaelScofield added a commit that referenced this pull request Oct 9, 2025
fix cargo fmt
Merge branch 'v0.54.x' into v0.54.x
Merge pull request #20 from kemingy/calc_overflow
fix lint
Merge branch 'v0.54.x' into v0.54.x
Merge pull request #19 from kemingy/lint
add test for statement convertion
fix: overflow in the calculation expr
fix the test in another pr
fix overflow
fix: lint and test
fix: add recursive protection to Convert
MichaelScofield added a commit that referenced this pull request Oct 9, 2025
fix cargo fmt
Merge branch 'v0.54.x' into v0.54.x
Merge pull request #20 from kemingy/calc_overflow
fix lint
Merge branch 'v0.54.x' into v0.54.x
Merge pull request #19 from kemingy/lint
add test for statement convertion
fix: overflow in the calculation expr
fix the test in another pr
fix overflow
fix: lint and test
fix: add recursive protection to Convert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants