Skip to content

Conversation

@kemingy
Copy link

@kemingy kemingy commented Aug 3, 2025

This fixes the overflow test in

#[test]
fn overflow() {
let expr = std::iter::repeat_n("1", 1000)
.collect::<Vec<_>>()
.join(" + ");
let sql = format!("SELECT {}", expr);
let mut statements = Parser::parse_sql(&GenericDialect {}, sql.as_str()).unwrap();
let statement = statements.pop().unwrap();
assert_eq!(statement.to_string(), sql);
}

@sunng87 sunng87 merged commit 76f17c3 into GreptimeTeam:v0.54.x Aug 3, 2025
3 of 9 checks passed
@kemingy kemingy deleted the calc_overflow branch August 3, 2025 15:04
MichaelScofield added a commit that referenced this pull request Aug 5, 2025
fix cargo fmt
Merge branch 'v0.54.x' into v0.54.x
Merge pull request #20 from kemingy/calc_overflow
fix lint
Merge branch 'v0.54.x' into v0.54.x
Merge pull request #19 from kemingy/lint
add test for statement convertion
fix: overflow in the calculation expr
fix the test in another pr
fix overflow
fix: lint and test
fix: add recursive protection to Convert
MichaelScofield added a commit that referenced this pull request Sep 29, 2025
fix cargo fmt
Merge branch 'v0.54.x' into v0.54.x
Merge pull request #20 from kemingy/calc_overflow
fix lint
Merge branch 'v0.54.x' into v0.54.x
Merge pull request #19 from kemingy/lint
add test for statement convertion
fix: overflow in the calculation expr
fix the test in another pr
fix overflow
fix: lint and test
fix: add recursive protection to Convert
MichaelScofield added a commit that referenced this pull request Oct 9, 2025
fix cargo fmt
Merge branch 'v0.54.x' into v0.54.x
Merge pull request #20 from kemingy/calc_overflow
fix lint
Merge branch 'v0.54.x' into v0.54.x
Merge pull request #19 from kemingy/lint
add test for statement convertion
fix: overflow in the calculation expr
fix the test in another pr
fix overflow
fix: lint and test
fix: add recursive protection to Convert
MichaelScofield added a commit that referenced this pull request Oct 9, 2025
fix cargo fmt
Merge branch 'v0.54.x' into v0.54.x
Merge pull request #20 from kemingy/calc_overflow
fix lint
Merge branch 'v0.54.x' into v0.54.x
Merge pull request #19 from kemingy/lint
add test for statement convertion
fix: overflow in the calculation expr
fix the test in another pr
fix overflow
fix: lint and test
fix: add recursive protection to Convert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants