Merged
Conversation
Opens a saved profile in $EDITOR with validation on close. If the edited profile fails validation, prompts to re-edit or discard. Handles $EDITOR with flags (e.g. "code --wait"), detects no-change exits, and catches empty profiles. Closes GreyhavenHQ#5 // ticktockbent
tito
approved these changes
Mar 27, 2026
Contributor
|
@TickTockBent thank you! Can you fix the lint that i can merge ? |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
greywall profiles edit <name>so users can tweak saved profiles without hunting for the file path and hand-validating JSON.$EDITOR(falls back to$VISUAL, thenvi)config.Loadcode --wait,emacs -nw)profiles listoutput and parent help text to mention the new commandCloses #5
Test plan
greywall profiles edit <saved-profile>opens editor, validates on closeEDITOR="code --wait"works (split on whitespace)profiles listgreywall profiles listfooter now shows the edit hint// squashing bugs, one cherry-pick at a time