-
-
Notifications
You must be signed in to change notification settings - Fork 24
add native macOS application menu integration #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 27 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
07faf65
add native macOS application menu integration
brtnfld 1135332
clang-format
brtnfld 3e3a520
clang-format
brtnfld fb6f873
clang format
brtnfld 85707ee
Use latest HDF5 snapshot with dynamic version detection in quality wo…
brtnfld b0842af
Fix HDF library extraction in CI workflows
brtnfld 16dfb60
removed hardcoded versions
brtnfld 181d0e9
removed hardcoded versions
brtnfld a0c244c
removed hardcoded versions
brtnfld b08e597
Merge branch 'master' into macmenu
brtnfld 04f480f
removed hardcoded versions
brtnfld 958c3e8
added error checks
brtnfld d18b10a
updated all workflow files to use PATTERN variables where the pattern…
brtnfld 8762ab1
Acquire SWT as maven dependency
mattjala de6b342
Update run scripts to be version-independent
mattjala a7b118a
Setup dependency JARs earlier in maven lifecycle
mattjala 4da2082
Update build guide
mattjala 73c15c2
Update windows run from source build script
mattjala d722a69
Correct cross-platform build guide
mattjala 256bd96
Revert change of lifecycle for JAR installation
mattjala 16291c5
Resolve 404 errors in deb/rpm tests
mattjala c457e5f
updates to menu fix
brtnfld 8dcbdca
clang-format
brtnfld c8ea261
clang-format
brtnfld 46e4634
clang-format
brtnfld 1a6f19e
addressed delay in settings menu
brtnfld d78b66d
Merge branch 'master' into macmenu
brtnfld cba59eb
Merge branch 'master' into macmenu
brtnfld 48abddf
New composite action to eliminate DRY violation
brtnfld 342cb86
the JAR installation duplication was already removed
brtnfld 1d945b0
fixed naming convention
brtnfld 15d7141
clang-format
brtnfld File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the globbing here because when there are multiple artifacts in the resulting tarball, the glob parsing will fail. I think this is probably only showing up as a diff since the master branch has been updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that if the runners get updated, "2404" will fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not opposed to making the version handling more generic, but this should be done in a separate PR away from the menu changes.