add native macOS application menu integration #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement SWT.ID_ABOUT and SWT.ID_PREFERENCES handlers to hook into the native macOS application menu (About/Preferences).
Centralize OS detection logic in ViewProperties.isMacOS() and replace inline checks.
Extract openUserOptionsDialog logic from createMenuBar to support reuse between the Tools menu and the macOS system menu.
Improve code readability by renaming semantic user option nodes and adding error logging for font creation failures.
brtnfld
requested review from
byrnHDF,
jhendersonHDF and
lrknox
as code owners
- maven-quality.yml: Use latest HDF5 snapshot with dynamic version detection - ci-macos.yml: Add debugging output and flexible archive detection - Both: Handle varying inner archive naming conventions"
… string is used multiple times
mattjala
reviewed
Jan 16, 2026
| # Determine file pattern based on whether base name is provided | ||
| if [ -n "${{ inputs.hdf4_artifact_basename }}" ]; then | ||
| PATTERN="${{ inputs.hdf4_artifact_basename }}-ubuntu-2404_gcc.tar.gz" | ||
| PATTERN="${{ inputs.hdf4_artifact_basename }}-ubuntu-*_gcc.tar.gz" |
Collaborator
There was a problem hiding this comment.
I removed the globbing here because when there are multiple artifacts in the resulting tarball, the glob parsing will fail. I think this is probably only showing up as a diff since the master branch has been updated.
Author
There was a problem hiding this comment.
The problem is that if the runners get updated, "2404" will fail.
Collaborator
There was a problem hiding this comment.
I'm not opposed to making the version handling more generic, but this should be done in a separate PR away from the menu changes.
mattjala
requested changes
Jan 16, 2026
Collaborator
mattjala
left a comment
mattjala
left a comment
There was a problem hiding this comment.
Looks good to go in once it's synced with master to remove the workflow changes
Dynamic HDF4 version detection (uses latest release by default) Performance fix for ViewProperties.isMacOS() (cached at class load time) Standardized input handling across all workflows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Integrate native macOS application menu items for About and Preferences in HDFView, centralize macOS detection, refactor code for reusability, and update GitHub workflows for dynamic versioning.
SWT.ID_ABOUTandSWT.ID_PREFERENCEShandlers inHDFView.javafor macOS application menu integration.ViewProperties.isMacOS().openUserOptionsDialoglogic inHDFView.javafor reuse.build-linux.yml,ci-linux.yml,ci-macos.yml,ci-windows.yml,maven-ci-orchestrator.yml,maven-quality.yml,maven-security.yml,publish-maven-packages.yml, andrelease-files.ymlto handle dynamic versioning and artifact naming for HDF4 and HDF5.HDFView.java.HDFView.java.This description was created by
for d78b66d. You can customize this summary. It will automatically update as commits are pushed.