Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #744 +/- ##
==========================================
- Coverage 39.70% 39.63% -0.07%
==========================================
Files 135 140 +5
Lines 22392 22697 +305
==========================================
+ Hits 8890 8997 +107
- Misses 13502 13700 +198 ☔ View full report in Codecov by Sentry. |
kpwelsh
requested changes
Jan 14, 2025
Collaborator
kpwelsh
left a comment
kpwelsh
left a comment
There was a problem hiding this comment.
A couple of minor things should be changed.
A couple of minor things could be changed.
Not 100% sure if there is a better way to do the xsimd or not.
psavery
reviewed
Jan 14, 2025
Collaborator
|
I ran a quick performance check on running |
Co-authored-by: Kevin Welsh <kevinwelsh132@gmail.com>
Co-authored-by: Kevin Welsh <kevinwelsh132@gmail.com>
Co-authored-by: Kevin Welsh <kevinwelsh132@gmail.com>
… of setuptools or perhaps windows that doesn't accept Paths
kpwelsh
approved these changes
Jan 30, 2025
Collaborator
Author
|
@psavery Just making sure I have your approval to merge this in before clicking the button |
This was referenced Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.