Skip to content

feat: add default outline to jets for better overlap visibility#837

Merged
EdwardMoyse merged 1 commit intoHSF:mainfrom
rx18-eng:fix/jet-outline-visibility
Mar 26, 2026
Merged

feat: add default outline to jets for better overlap visibility#837
EdwardMoyse merged 1 commit intoHSF:mainfrom
rx18-eng:fix/jet-outline-visibility

Conversation

@rx18-eng
Copy link
Copy Markdown
Collaborator

@rx18-eng rx18-eng commented Mar 19, 2026

Summary

  • reverted rainbow selection animation to static amber glow ->simpler,less distracting
  • replaced wireframe jet overlay with Fresnel shader -> opaque edges, transparent inside, tracks visible through jets
  • fixed hover flicker bug
  • fixed clicks not registering on first try
  • bumped click threshold from 5px to 10px
  • fixed share-link dialog calling wrong method

What changed

  • Jets: wireframe overlay replaced with a Fresnel shader. Edges facing away from camera are more opaque, interior is see-through.

  • Selection: rainbow animation reverted to static amber glow for selected objects, blue for hover. Outlines are children of the mesh now so they follow transforms.

Bugs I found while testing:

  • hover was flickering because the raycaster was hitting the outline LineSegments instead of the actual mesh -> fixed by disabling raycast on outlines.
  • Clicks weren't registering on first try because the hover system only raycasts every few frames -> added a fresh raycast fallback on click. Also bumped click-vs-drag threshold to 10px since 5px was too sensitive.
Recording.2026-03-23.030519.1.1.mp4
Screenshot 2026-03-23 023456

Closes #839 #571

@rx18-eng
Copy link
Copy Markdown
Collaborator Author

Hey @EdwardMoyse Please let me know your thoughts on this :)

@EdwardMoyse
Copy link
Copy Markdown
Collaborator

Hi @rx18-eng - I would like to discuss this with @sponce but I have to say that I don't really like this visually. Jets in physics are not physical objects but a shower of particles, and I think a wireframe like this is not very appealing, nor is it really giving a hint of the underlying physics.

Part of the reason for my delay was I was actually looking at the code, trying to work out how to revert the rainbow selection effect introduced in #721 (which in retrospect is too much) in favour of the much more elegant (in my opinion) outline effect we had before.

Back to this: I think it would be nice to see if we could distinguish the jets with a more subtle effect, perhaps with shaders, where the edges are opaque and the inside is more transparent? But this would perhaps be something to brainstorm.

@rx18-eng
Copy link
Copy Markdown
Collaborator Author

rx18-eng commented Mar 20, 2026

Thanks for your review @EdwardMoyse ! Also just wanted to inform you this is my temporary account as replacement for remo-lab(untill the issue gets resolved :) )

@rx18-eng rx18-eng force-pushed the fix/jet-outline-visibility branch 2 times, most recently from 88e3da1 to 95cbd31 Compare March 22, 2026 21:27
@rx18-eng
Copy link
Copy Markdown
Collaborator Author

hey @EdwardMoyse , updated the PR description. main changes: reverted rainbow to amber glow, replaced wireframe jets with fresnel shader (opaque edges, transparent inside like you suggested), and fixed a few interaction bugs i found while testing (hover flicker, clicks not registering, click threshold too sensitive).

@rx18-eng
Copy link
Copy Markdown
Collaborator Author

CI is green now :) Please let me know if you want any modifications !

@rx18-eng
Copy link
Copy Markdown
Collaborator Author

Also now do you like this visually?

Hi @rx18-eng - I would like to discuss this with @sponce but I have to say that I don't really like this visually. Jets in physics are not physical objects but a shower of particles, and I think a wireframe like this is not very appealing, nor is it really giving a hint of the underlying physics.

Part of the reason for my delay was I was actually looking at the code, trying to work out how to revert the rainbow selection effect introduced in #721 (which in retrospect is too much) in favour of the much more elegant (in my opinion) outline effect we had before.

Back to this: I think it would be nice to see if we could distinguish the jets with a more subtle effect, perhaps with shaders, where the edges are opaque and the inside is more transparent? But this would perhaps be something to brainstorm.

…n UX (HSF#839)

Signed-off-by: rx18-eng <remopanda78@gmail.com>
@rx18-eng rx18-eng force-pushed the fix/jet-outline-visibility branch from 95cbd31 to 0f6da97 Compare March 24, 2026 20:24
@rx18-eng
Copy link
Copy Markdown
Collaborator Author

@EdwardMoyse @sponce, I've pushed some changes to address both of your follow-up points on the fix/jet-outline-visibility branch.

What changed:

  • Selection now uses OutlinePass instead of EdgesGeometry — this gives true silhouette outlines (boundary only, no internal mesh edges). Jets no longer show all the cone triangle edges, just the outer contour. This should match the pre-Selection manager expansion pack #721 behavior Edward referenced.
  • Pulsing animation on selection — the outline breathes in/out so there's always "something moving" as Sebastien suggested.
  • Configurable selection color via setSelectionColor() — defaults to amber which contrasts well against ATLAS blue/cyan objects, but experiments like LHCb (where calorimeter deposits are amber) can set a different color.
  • Hover unchanged — still uses EdgesGeometry with blue outlines for lightweight immediate feedback.

Would love your thoughts on how this looks.

f1db22bf-d484-4501-a4eb-32f493a3de93.mp4

@sponce
Copy link
Copy Markdown
Collaborator

sponce commented Mar 25, 2026

I like a lot the glowing amber. Together with the ability to change color, I think it's a better alternative to the rainbow effect.

@EdwardMoyse
Copy link
Copy Markdown
Collaborator

Apologies for being a bit unresponsive at the moment, but it's a busy time. Anyway, I agree it looks good but in my local testing it fails (windows, firefox):

image

It does seem to work on Chrome, so I'm not quite sure what is going on. But I would also want to check on phones etc to make sure we're not breaking them too.

@EdwardMoyse
Copy link
Copy Markdown
Collaborator

Okay, I think my issue might be independent of this PR. :-/

@rx18-eng
Copy link
Copy Markdown
Collaborator Author

rx18-eng commented Mar 25, 2026

Yes,I was testing it now in fiirefox as well , its working fine there

@rx18-eng
Copy link
Copy Markdown
Collaborator Author

Shall i tweak anything else on this?

@rx18-eng
Copy link
Copy Markdown
Collaborator Author

rx18-eng commented Mar 25, 2026

Apologies for being a bit unresponsive at the moment, but it's a busy time. Anyway, I agree it looks good but in my local testing it fails (windows, firefox):

Totally get it . No worries on that , I was just eager to know your thoughts on this !

@EdwardMoyse EdwardMoyse merged commit ec07b22 into HSF:main Mar 26, 2026
2 checks passed
@EdwardMoyse
Copy link
Copy Markdown
Collaborator

This is great! Thanks for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possibly revert the rainbow selection effect

3 participants