feat: add default outline to jets for better overlap visibility#837
feat: add default outline to jets for better overlap visibility#837EdwardMoyse merged 1 commit intoHSF:mainfrom
Conversation
|
Hey @EdwardMoyse Please let me know your thoughts on this :) |
|
Hi @rx18-eng - I would like to discuss this with @sponce but I have to say that I don't really like this visually. Jets in physics are not physical objects but a shower of particles, and I think a wireframe like this is not very appealing, nor is it really giving a hint of the underlying physics. Part of the reason for my delay was I was actually looking at the code, trying to work out how to revert the rainbow selection effect introduced in #721 (which in retrospect is too much) in favour of the much more elegant (in my opinion) outline effect we had before. Back to this: I think it would be nice to see if we could distinguish the jets with a more subtle effect, perhaps with shaders, where the edges are opaque and the inside is more transparent? But this would perhaps be something to brainstorm. |
|
Thanks for your review @EdwardMoyse ! Also just wanted to inform you this is my temporary account as replacement for remo-lab(untill the issue gets resolved :) ) |
88e3da1 to
95cbd31
Compare
|
hey @EdwardMoyse , updated the PR description. main changes: reverted rainbow to amber glow, replaced wireframe jets with fresnel shader (opaque edges, transparent inside like you suggested), and fixed a few interaction bugs i found while testing (hover flicker, clicks not registering, click threshold too sensitive). |
|
CI is green now :) Please let me know if you want any modifications ! |
|
Also now do you like this visually?
|
…n UX (HSF#839) Signed-off-by: rx18-eng <remopanda78@gmail.com>
95cbd31 to
0f6da97
Compare
|
@EdwardMoyse @sponce, I've pushed some changes to address both of your follow-up points on the fix/jet-outline-visibility branch. What changed:
Would love your thoughts on how this looks. f1db22bf-d484-4501-a4eb-32f493a3de93.mp4 |
|
I like a lot the glowing amber. Together with the ability to change color, I think it's a better alternative to the rainbow effect. |
|
Okay, I think my issue might be independent of this PR. :-/ |
|
Yes,I was testing it now in fiirefox as well , its working fine there |
|
Shall i tweak anything else on this? |
Totally get it . No worries on that , I was just eager to know your thoughts on this ! |
|
This is great! Thanks for this. |
Summary
What changed
Jets: wireframe overlay replaced with a Fresnel shader. Edges facing away from camera are more opaque, interior is see-through.
Selection: rainbow animation reverted to static amber glow for selected objects, blue for hover. Outlines are children of the mesh now so they follow transforms.
Bugs I found while testing:
Recording.2026-03-23.030519.1.1.mp4
Closes #839 #571