Muna Naher ass.week02 #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remarcmij
requested changes
Jan 24, 2026
remarcmij
left a comment
remarcmij
left a comment
There was a problem hiding this comment.
Hi @MunaNasher, apart from the indentation, the tasks 1 and 2 are fine. However, there is still any issue with task 3 that I would like you to fix. Good luck!
| import promptSync from 'prompt-sync'; | ||
| const prompt = promptSync(); | ||
|
|
||
| let year = prompt("Enter a year:"); |
There was a problem hiding this comment.
It is customary to use a space after a colon:
Suggested change
| let year = prompt("Enter a year:"); | |
| let year = prompt("Enter a year: "); |
Comment on lines
+7
to
+12
| year = Number(year); | ||
|
|
||
| // check the input vaildation | ||
| if (isNaN(year) || year < 1 || year > 9999) { | ||
| console.log("Invalid year!"); | ||
| } else { |
There was a problem hiding this comment.
Use indentation to make your code more readable and easier to understand, refer to the Code Style section of the learning materials.
https://hub.hackyourfuture.nl/Code-style-Basics-2b050f64ffc9807d912ed59b0c72440d
Suggested change
| year = Number(year); | |
| // check the input vaildation | |
| if (isNaN(year) || year < 1 || year > 9999) { | |
| console.log("Invalid year!"); | |
| } else { | |
| year = Number(year); | |
| // check the input vaildation | |
| if (isNaN(year) || year < 1 || year > 9999) { | |
| console.log("Invalid year!"); | |
| } else { |
Comment on lines
+14
to
+17
| const isAdmin = username === "admin" && password === "Hack1234"; | ||
| const isUser = username === "user" && password === "7654321"; | ||
|
|
||
| if (isAdmin || isUser) { |
There was a problem hiding this comment.
Indentation:
Suggested change
| const isAdmin = username === "admin" && password === "Hack1234"; | |
| const isUser = username === "user" && password === "7654321"; | |
| if (isAdmin || isUser) { | |
| const isAdmin = username === "admin" && password === "Hack1234"; | |
| const isUser = username === "user" && password === "7654321"; | |
| if (isAdmin || isUser) { |
| } | ||
|
|
||
|
|
||
| EUR_USD_RATE |
| } else { | ||
| const eurAmount = usdAmountNum / eur_usd_rate; | ||
| const eurAmount = usdAmountNum / EUR_USD_RATE; // eur_usd_rate is not defined, it should be EUR_USD_RATE, Bug3 | ||
| console.log(usdAmountNum.toFixed(2) + ' USD is equal to ' + usdAmountNum.toFixed(2) + ' EUR.'); |
There was a problem hiding this comment.
When I run your converter, it doesn't produce correct results for USD to EUR:
% node converter.js
Hello and welcome to the currency converter. Please choose:
1: Convert EUR to USD
2: Convert USD to EUR
Select your option [1 or 2]: 2
Enter amount in USD: 1
1.00 USD is equal to 1.00 EUR.
1 USD !== 1 EUR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.