Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions task-1/leap-year.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,20 @@
import promptSync from 'prompt-sync';
const prompt = promptSync();

let year = prompt("Enter a year:");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is customary to use a space after a colon:

Suggested change
let year = prompt("Enter a year:");
let year = prompt("Enter a year: ");


// Write your code here
// Guidance:
// Step 1: prompt the user to enter a year
// Step 2: convert the user input to a number so we can perform calculations
// Step 3: Implement the logic
// convert the input to number
year = Number(year);

// check the input vaildation
if (isNaN(year) || year < 1 || year > 9999) {
console.log("Invalid year!");
} else {
Comment on lines +7 to +12

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use indentation to make your code more readable and easier to understand, refer to the Code Style section of the learning materials.

https://hub.hackyourfuture.nl/Code-style-Basics-2b050f64ffc9807d912ed59b0c72440d

Suggested change
year = Number(year);
// check the input vaildation
if (isNaN(year) || year < 1 || year > 9999) {
console.log("Invalid year!");
} else {
year = Number(year);
// check the input vaildation
if (isNaN(year) || year < 1 || year > 9999) {
console.log("Invalid year!");
} else {


// leap year
if ((year % 4 === 0 && year % 100 !== 0) || year % 400 === 0) {
console.log("Yes, " + year + " is a leap year");
} else {
console.log("No, " + year + " is not a leap year");
}
}
20 changes: 17 additions & 3 deletions task-2/login.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,23 @@ import { errorMessage, successMessage } from './app.js';
let incorrectAttempts = 0;

function onLogin(username, password) {
// Write your code here.
// Use the variables 'username' and 'password' to access the input values
// Use incorrectAttempts to track the number of failed attempts

if (incorrectAttempts >= 4) {
errorMessage("Login blocked: Too many incorrect attempts");
return;
}


const isAdmin = username === "admin" && password === "Hack1234";
const isUser = username === "user" && password === "7654321";

if (isAdmin || isUser) {
Comment on lines +14 to +17

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation:

Suggested change
const isAdmin = username === "admin" && password === "Hack1234";
const isUser = username === "user" && password === "7654321";
if (isAdmin || isUser) {
const isAdmin = username === "admin" && password === "Hack1234";
const isUser = username === "user" && password === "7654321";
if (isAdmin || isUser) {

successMessage("Logged in successfully");
} else {
incorrectAttempts++;
errorMessage("Incorrect credentials");
}

}

// Do not change the line below
Expand Down
12 changes: 8 additions & 4 deletions task-3/converter.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const prompt = promptSync();
const EUR_USD_RATE = 1.1643;

// Menu display
conole.log("Hello and welcome to the currency converter. Please choose: ");
console.log("Hello and welcome to the currency converter. Please choose: "); // Incorrect splleing, Bug1
console.log("1: Convert EUR to USD");
console.log("2: Convert USD to EUR");
const menuSelection = prompt("Select your option [1 or 2]: ");
Expand All @@ -16,7 +16,8 @@ if (menuSelection === "1") {
// EUR to USD
const eurAmountInput = prompt("Enter amount in EUR: ");
const eurAmountNum = Number(eurAmountInput);
if (Number.isNaN(eurAmountNum) || eurAmountNum > 0) {
// the condition is wrong, eurAmountNum > 0 should be eurAmountNum <=0 ,Bug2
if (Number.isNaN(eurAmountNum) || eurAmountNum <= 0) {
console.log("Please enter a valid positive number for the amount.");
} else {
const usdAmount = eurAmountNum * EUR_USD_RATE;
Expand All @@ -25,13 +26,16 @@ if (menuSelection === "1") {
} else if (menuSelection === "2") {
// USD to EUR
const usdAmountInput = prompt("Enter amount in USD: ");
const usdAmountNum = Number(usdAmountInput);
const usdAmountNum = Number(usdAmountInput);
if (Number.isNaN(usdAmountNum) || usdAmountNum < 0) {
console.log("Please enter a valid positive number for the amount.");
} else {
const eurAmount = usdAmountNum / eur_usd_rate;
const eurAmount = usdAmountNum / EUR_USD_RATE; // eur_usd_rate is not defined, it should be EUR_USD_RATE, Bug3
console.log(usdAmountNum.toFixed(2) + ' USD is equal to ' + usdAmountNum.toFixed(2) + ' EUR.');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I run your converter, it doesn't produce correct results for USD to EUR:

% node converter.js
Hello and welcome to the currency converter. Please choose: 
1: Convert EUR to USD
2: Convert USD to EUR
Select your option [1 or 2]: 2


Enter amount in USD: 1
1.00 USD is equal to 1.00 EUR.

1 USD !== 1 EUR

}
} else {
console.log("Invalid selection. Please choose either 1 or 2.");
}


EUR_USD_RATE

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this line?

Loading