Add content to week 5 of React module #228
Conversation
I double-checked the Vercel docs (https://vercel.com/docs/git) confirming that deployments in the Hobby (free) plan require a public repository on GitHub. The Vercel website (https://vercel.com/pricing) promises furthermore that the Hobby plan offers automated deployments from imported repositories.
adamblanchard
left a comment
adamblanchard
left a comment
There was a problem hiding this comment.
Sweet! Thanks a lot for these changes.
-
I made a commit to fix the stuff on gitbook. I ran
npm run generate:gitbook-summarywhich outputs the structure needed in the sidebar, and then manually copied the react section into SUMMARY.md (which is a gitbook file that they use to populate the sidebar). Once the pages are in the sidebar, they are classed as "internal gitbook pages" so then the links on the readme link properly to the gitbook page (rather than github). I just made a small tweak to make all the link formats consistent (see my commit). -
I don't have any ideas for week 4 assignment. Would you like to create a separate issue for that, and see if we can get anyone else to volunteer some ideas?
| - Demonstrate programmatic navigation using `router.push` and `router.replace` | ||
|
|
||
| ### Optional Advanced: Server Functions (or Server Actions) & API Routes | ||
| ### Optional Advanced: Server Functions & API Routes |
There was a problem hiding this comment.
What makes this optional?
I don't think i'm the biggest fan of optional content, since it's not very explicit to a mentor whether they should cover it or not.
I'd either commit to it, or write clear expectations underneath to explain why or why not to teach it. But i lean to the former option, if possible.
There was a problem hiding this comment.
One argument for optional content is that time during a lesson can fly. Or there can be time left in the end. Both happened to me before. In that case an optional topic is nice.
But I agree with the sentiment. The program should feel complete and ideally shouldn't have variables.
Perhaps I was lacking confidence making it required, because it is kind of a backend topic. I removed the optional prefix. I think that's the best "fix" for now.
You will not be impressed though doing a repository-wide search for "optional" 😅
There was a problem hiding this comment.
Haha, sorry to hold you to that standard then, if we have done it in so many other places! Appreciate your perspective on it, that's a fair point. Let's move it forward for now anywayz.
|
I created a new issue for the Week 4 assignment: #230 |
|
Please check once again. I made some smaller changes and tried to address your comments 😊 |
Added
Changed
Resources