-
Notifications
You must be signed in to change notification settings - Fork 9
Add content to week 5 of React module #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a4b44fc
feat(react): Remove TODO: comment from assignment, it looks good!
te-online d018f4c
feat(react): Fill blank sections for Server Functions and Vercel chap…
te-online d720192
fix(react): Lesson plan -> Session plan
te-online e79d292
fix(react): Prettier issue
te-online 853a120
fix(react): Linter complaining about duplicate headlines
te-online 502a603
updated gitbook sidebar and fixed links
adamblanchard 0cfdaef
fix(react): Remove "optional" prefix from server functions section
te-online aee228f
fix(react): Adjust wording in Week 5 session plan
te-online 4f38292
feat(react): Week 5: Add link to backend course where it's mentioned
te-online File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,6 @@ | ||
| # Assignment | ||
|
|
||
| TODO: Proposal: Verify if this would be ok? | ||
|
|
||
| - Deploy a Next.js app in which you cover the exercises from Week 5 to Vercel | ||
| - Deploy a Next.js app, in which you cover the exercises from Week 5, to Vercel | ||
| - Make sure you push to a new GitHub repository and that it is public | ||
| - Connect the repository to Vercel and fix any potential deployment issues | ||
| - Share the working deployment URL in the team Slack channel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What makes this optional?
I don't think i'm the biggest fan of optional content, since it's not very explicit to a mentor whether they should cover it or not.
I'd either commit to it, or write clear expectations underneath to explain why or why not to teach it. But i lean to the former option, if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One argument for optional content is that time during a lesson can fly. Or there can be time left in the end. Both happened to me before. In that case an optional topic is nice.
But I agree with the sentiment. The program should feel complete and ideally shouldn't have variables.
Perhaps I was lacking confidence making it required, because it is kind of a backend topic. I removed the optional prefix. I think that's the best "fix" for now.
You will not be impressed though doing a repository-wide search for "optional" 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, sorry to hold you to that standard then, if we have done it in so many other places! Appreciate your perspective on it, that's a fair point. Let's move it forward for now anywayz.