Strikes removed from api/cohorts and cohorts page on client#291
Merged
MBreathe merged 1 commit intoHackYourFuture:mainfrom Feb 2, 2026
Merged
Conversation
… removed strikes from cohorts page in client, ran npm audit fix on server
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes the "strikes" field from the trainee summary data in both the backend API and frontend UI for the cohorts page. The changes streamline the trainee data model by eliminating the display of strike counts in the cohort overview.
Changes:
- Removed
strikesproperty from theTraineeSummaryinterface and response construction in the backend cohorts controller - Removed
strikesfield from the API schema definition - Removed "Strikes" column from the cohort trainees table in the UI
- Updated AWS SDK dependencies from version ~3.830.0 to 3.980.0
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| server/src/controllers/CohortsController.ts | Removed strikes property from TraineeSummary interface and response object construction |
| server/api.yaml | Removed strikes field from the API response schema |
| client/src/features/cohorts/components/CohortAccordion.tsx | Removed "Strikes" table column header and data cell from the cohort trainees table |
| server/package-lock.json | Updated AWS SDK and related dependencies (unrelated to strikes removal) |
Files not reviewed (1)
- server/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the "strikes" field from the trainee summary in both the backend and frontend, as well as from the API specification. The change streamlines the trainee data model and updates the UI to reflect this removal.
Backend/API changes:
strikesproperty from theTraineeSummaryinterface and from the response object construction inCohortsController.strikesfield from the API response schema inapi.yaml.Frontend/UI changes:
CohortAccordion.tsx.