Merged
Conversation
…ons, collums in tables now follow the same sizing
MBreathe
requested review from
Aya-Alabrash,
sima-milli and
stasel
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request contains targeted styling improvements to fix layout issues and improve visual consistency across the application. The changes address viewport height overflow issues and refine icon spacing in table layouts.
Changes:
- Modified container heights from
100vhto95vhto prevent viewport overflow - Removed explicit width constraint from
.Appcontainer to fix potential horizontal scrollbar issues - Enhanced table cell styling with minimum width and right-alignment for contact icons
- Removed unnecessary right margins from Material-UI icons within IconButton components
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| client/src/styles/index.css | Changed .App container from fixed height: 100vh with width: 100vw to flexible min-height: 95vh without explicit width to prevent overflow and scrollbar issues |
| client/src/features/trainee-profile/profile/ProfileSidebar.tsx | Reduced sidebar height from 100vh to 95vh for consistency with overall app height changes |
| client/src/features/cohorts/components/CohortAccordion.tsx | Added minWidth: '240px' to job path cell, aligned contact icons to end, and removed redundant mr: 1 margins from icons already wrapped in IconButton components |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HackYourFutures
temporarily deployed
to
dojo-frontend-styling-q-4z5nnh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes minor UI adjustments to improve the layout and alignment of elements in the cohort and profile sidebar components, as well as a small update to the overall application styling. The changes primarily focus on improving table cell widths, icon spacing, and the height of main containers for a more consistent and visually appealing interface.
UI layout and alignment improvements:
CohortAccordionto ensure better alignment and prevent text overflow.endfor improved visual consistency.EmailIcon,GitHubIcon,LinkedInIcon) for a cleaner look.Container height adjustments:
ProfileSidebarcontainer from100vhto95vhto better fit within the viewport and avoid overflow..Appcontainer from a fixed100vhheight to amin-height: 95vhfor more flexible layout and to prevent unwanted scrolling.