Skip to content

Styling fixes #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MBreathe merged 1 commit into from
Feb 2, 2026
Merged

Styling fixes #292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions client/src/features/cohorts/components/CohortAccordion.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ const CohortAccordion = ({ cohortInfo }: CohortAccordionProps) => {
<TraineeAvatar imageURL={trainee.thumbnailURL ?? ''} altText={trainee.displayName}></TraineeAvatar>
</TableCell>
<TableCell>{trainee.displayName}</TableCell>
<TableCell sx={{ whiteSpace: 'nowrap' }}>
<TableCell sx={{ whiteSpace: 'nowrap', minWidth: '240px' }}>
{trainee.LearningStatus === LearningStatus.Graduated ? (
<SidebarJobPath jobPath={trainee.JobPath}></SidebarJobPath>
) : (
Expand All @@ -87,7 +87,7 @@ const CohortAccordion = ({ cohortInfo }: CohortAccordionProps) => {
<TableCell sx={{ color: getScoreColor(trainee.averageTestScore) }}>
{trainee.averageTestScore !== null ? trainee.averageTestScore.toFixed(1) : '-'}
</TableCell>
<TableCell sx={{ whiteSpace: 'nowrap' }} onClick={(e) => e.stopPropagation()}>
<TableCell sx={{ whiteSpace: 'nowrap', textAlign: 'end' }} onClick={(e) => e.stopPropagation()}>
<div>
{trainee.slackID && (
<IconButton aria-label="Slack Id" href={`slack://user?team=T0EJTUQ87&id=${trainee.slackID}`}>
Expand All @@ -96,7 +96,7 @@ const CohortAccordion = ({ cohortInfo }: CohortAccordionProps) => {
)}
{trainee.email && (
<IconButton aria-label="email" href={`mailto:${trainee.email}`}>
<EmailIcon sx={{ color: 'action.active', mr: 1 }} />
<EmailIcon sx={{ color: 'action.active' }} />
</IconButton>
)}
{trainee.githubHandle && (
Expand All @@ -105,12 +105,12 @@ const CohortAccordion = ({ cohortInfo }: CohortAccordionProps) => {
href={`https://github.com/${trainee.githubHandle}`}
target="_blank"
>
<GitHubIcon sx={{ color: 'action.active', mr: 1 }} />
<GitHubIcon sx={{ color: 'action.active' }} />
</IconButton>
)}
{trainee.linkedIn && (
<IconButton aria-label="LinkedIn URL" href={trainee.linkedIn} target="_blank">
<LinkedInIcon sx={{ color: 'action.active', mr: 1 }} />
<LinkedInIcon sx={{ color: 'action.active' }} />
</IconButton>
)}
</div>
Expand Down
2 changes: 1 addition & 1 deletion client/src/features/trainee-profile/profile/ProfileSidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const ProfileSidebar = ({ traineeId }: ProfileSidebarProps) => {
gap={2}
color="black"
bgcolor="var(--hyf-beige)"
height="100vh"
height="95vh"
paddingX={4}
paddingY={4}
>
Expand Down
3 changes: 1 addition & 2 deletions client/src/styles/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,7 @@ body {
}

.App {
height: 100vh;
width: 100vw;
min-height: 95vh;
color: #333;
background: #fff;
}
Expand Down
Loading