Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to reduce excess Docker image creation by updating the Docker image tag strategy and streamlining the workflow configuration.
- Updated the Docker image tag names in the README to use "dev-main" and "1.x.x".
- Simplified the Docker workflow by replacing commit-specific tags (e.g., "dev-{{sha}}") with a static tag ("dev-main").
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Updated documentation for Docker image tags to reflect the new naming strategy. |
| .github/workflows/docker-image.yml | Modified Docker tag configuration to use a static "dev-main" tag for main branch. |
Comments suppressed due to low confidence (1)
README.md:23
- Ensure that the README documentation clearly explains the reason for switching from a dynamic tag (dev-) to a static tag (dev-main), and clarify how versioning (1.x.x) is handled compared to previous version tags.
- **`dev-main`**: Development builds from main branch
| type=raw,value=latest,enable=${{ startsWith(github.ref, 'refs/tags/v') }} | ||
| type=raw,value=dev-{{sha}},enable={{is_default_branch}} | ||
| type=raw,value=dev-{{sha}},enable=${{ github.event.inputs.force_push == 'true' }} | ||
| type=raw,value=dev-main,enable={{is_default_branch}} |
There was a problem hiding this comment.
Review the change from using dynamic 'dev-{{sha}}' to a static 'dev-main' tag to ensure that it meets traceability and debugging needs. If commit-specific identification is required for troubleshooting, consider incorporating an additional tag or logging mechanism.
Suggested change
| type=raw,value=dev-main,enable={{is_default_branch}} | |
| type=raw,value=dev-main,enable={{is_default_branch}} | |
| type=raw,value=dev-${{ github.sha }},enable={{is_default_branch}} |
reppiee
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to reduce excess Docker image creation by updating the Docker image tag strategy and streamlining the workflow configuration.
Updated the Docker image tag names in the README to use "dev-main" and "1.x.x".
Simplified the Docker workflow by replacing commit-specific tags (e.g., "dev-{{sha}}") with a static tag ("dev-main").