Skip to content

Reduce excess docker image creation #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philipkocanda merged 1 commit into from
Jun 17, 2025
Merged

Reduce excess docker image creation #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/docker-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,8 @@ jobs:
tags: |
type=ref,event=pr
type=semver,pattern={{version}}
type=semver,pattern={{major}}.{{minor}}
type=semver,pattern={{major}}
type=raw,value=latest,enable=${{ startsWith(github.ref, 'refs/tags/v') }}
type=raw,value=dev-{{sha}},enable={{is_default_branch}}
type=raw,value=dev-{{sha}},enable=${{ github.event.inputs.force_push == 'true' }}
type=raw,value=dev-main,enable={{is_default_branch}}
Copy link

Copilot AI Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review the change from using dynamic 'dev-{{sha}}' to a static 'dev-main' tag to ensure that it meets traceability and debugging needs. If commit-specific identification is required for troubleshooting, consider incorporating an additional tag or logging mechanism.

Suggested change
type=raw,value=dev-main,enable={{is_default_branch}}
type=raw,value=dev-main,enable={{is_default_branch}}
type=raw,value=dev-${{ github.sha }},enable={{is_default_branch}}

Copilot uses AI. Check for mistakes.

- name: Build and push Docker image
uses: docker/build-push-action@v5
Expand Down
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ A Docker image that provides access to HackerOne's GraphQL API through the Model
## Docker Image Tags

- **`latest`**: Latest stable release (only updated on version releases)
- **`dev-<commit>`**: Development builds from main branch (e.g., `dev-abc1234`)
- **`v1.0.0`**: Specific version releases
- **`dev-main`**: Development builds from main branch
- **`1.x.x`**: Specific version releases
- **`pr-<ref>`**: Pull request builds

## Environment Variables
Expand Down Expand Up @@ -78,7 +78,7 @@ A Docker image that provides access to HackerOne's GraphQL API through the Model

To create a new release:

1. Create a [new release in GitHub](https://github.com/Hacker0x01/hackerone-graphql-mcp-server/releases/new)
1. Create a [new release in GitHub](https://github.com/Hacker0x01/hackerone-graphql-mcp-server/releases/new).

2. GitHub Actions will automatically:
- Build multi-architecture images (amd64, arm64)
Expand Down