remove json feature from reqwest #304
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description <!-- Provide a brief description of the changes in this PR --> fixing hql bugs and refactoring analyzer ## Related Issues <!-- Link to any related issues using #issue_number --> Closes #244 #245 #247 #249 ## Checklist when merging to main <!-- Mark items with "x" when completed --> - [x] No compiler warnings (if applicable) - [x] Code is formatted with `rustfmt` - [x] No useless or dead code (if applicable) - [x] Code is easy to understand - [x] Doc comments are used for all functions, enums, structs, and fields (where appropriate) - [x] All tests pass - [x] Performance has not regressed (assuming change was not to fix a bug) - [x] Version number has been updated in `helix-cli/Cargo.toml` and `helixdb/Cargo.toml` - [x] Lines are kept under 100 characters where possible - [x] Code is good ## Additional Notes <!-- Add any additional information that would be helpful for reviewers -->
## Description <!-- Provide a brief description of the changes in this PR --> [bug/fixing issue with update traversal step and reading config](2bae4c9) ## Related Issues <!-- Link to any related issues using #issue_number --> Closes # ## Checklist when merging to main <!-- Mark items with "x" when completed --> - [x] No compiler warnings (if applicable) - [x] Code is formatted with `rustfmt` - [x] No useless or dead code (if applicable) - [x] Code is easy to understand - [x] Doc comments are used for all functions, enums, structs, and fields (where appropriate) - [x] All tests pass - [x] Performance has not regressed (assuming change was not to fix a bug) - [x] Version number has been updated in `helix-cli/Cargo.toml` and `helixdb/Cargo.toml` - [x] Lines are kept under 100 characters where possible - [x] Code is good ## Additional Notes <!-- Add any additional information that would be helpful for reviewers -->
## Description <!-- Provide a brief description of the changes in this PR --> ## Related Issues <!-- Link to any related issues using #issue_number --> Closes # ## Checklist when merging to main <!-- Mark items with "x" when completed --> - [ ] No compiler warnings (if applicable) - [ ] Code is formatted with `rustfmt` - [ ] No useless or dead code (if applicable) - [ ] Code is easy to understand - [ ] Doc comments are used for all functions, enums, structs, and fields (where appropriate) - [ ] All tests pass - [ ] Performance has not regressed (assuming change was not to fix a bug) - [ ] Version number has been updated in `helix-cli/Cargo.toml` and `helixdb/Cargo.toml` - [ ] Lines are kept under 100 characters where possible - [ ] Code is good ## Additional Notes <!-- Add any additional information that would be helpful for reviewers -->
…#263) ## Description <!-- Provide a brief description of the changes in this PR --> - Implemented soft deleting vectors. Done by `DROP <traversal resulting in vectors>` - Made HQL tests fail properly when errors are present - Fixed issues with ID property access e.g. `N<User>::ID` or `N<User>::{user_id: ID}` now work - Spreading fields now works properly ## Related Issues <!-- Link to any related issues using #issue_number --> Closes #209 ## Checklist when merging to main <!-- Mark items with "x" when completed --> - [x] No compiler warnings (if applicable) - [x] Code is formatted with `rustfmt` - [x] No useless or dead code (if applicable) - [x] Code is easy to understand - [x] Doc comments are used for all functions, enums, structs, and fields (where appropriate) - [x] All tests pass - [x] Performance has not regressed (assuming change was not to fix a bug) - [x] Version number has been updated in `helix-cli/Cargo.toml` and `helixdb/Cargo.toml` - [x] Lines are kept under 100 characters where possible - [x] Code is good ## Additional Notes <!-- Add any additional information that would be helpful for reviewers -->
…xes for HQL analyzer (#271) ## Description <!-- Provide a brief description of the changes in this PR --> rewritten server infra, fixed issues with cli, more bug fixes for HQL analyzer ## Related Issues <!-- Link to any related issues using #issue_number --> Closes # ## Checklist when merging to main <!-- Mark items with "x" when completed --> - [ ] No compiler warnings (if applicable) - [ ] Code is formatted with `rustfmt` - [ ] No useless or dead code (if applicable) - [ ] Code is easy to understand - [ ] Doc comments are used for all functions, enums, structs, and fields (where appropriate) - [ ] All tests pass - [ ] Performance has not regressed (assuming change was not to fix a bug) - [ ] Version number has been updated in `helix-cli/Cargo.toml` and `helixdb/Cargo.toml` - [ ] Lines are kept under 100 characters where possible - [ ] Code is good ## Additional Notes <!-- Add any additional information that would be helpful for reviewers -->
…trospection, fixing edge access hql bugs (#294) ## Description <!-- Provide a brief description of the changes in this PR --> removing warnings, adding clippy, improving cli, adding introspection, fixing edge access hql bugs ## Related Issues <!-- Link to any related issues using #issue_number --> Closes # ## Checklist when merging to main <!-- Mark items with "x" when completed --> - [ ] No compiler warnings (if applicable) - [ ] Code is formatted with `rustfmt` - [ ] No useless or dead code (if applicable) - [ ] Code is easy to understand - [ ] Doc comments are used for all functions, enums, structs, and fields (where appropriate) - [ ] All tests pass - [ ] Performance has not regressed (assuming change was not to fix a bug) - [ ] Version number has been updated in `helix-cli/Cargo.toml` and `helixdb/Cargo.toml` - [ ] Lines are kept under 100 characters where possible - [ ] Code is good ## Additional Notes <!-- Add any additional information that would be helpful for reviewers -->
…by (#299) ## Description <!-- Provide a brief description of the changes in this PR --> impr + fix/implementing mcp nested filtering, env sourcing and order by ## Related Issues <!-- Link to any related issues using #issue_number --> Closes # ## Checklist when merging to main <!-- Mark items with "x" when completed --> - [ ] No compiler warnings (if applicable) - [ ] Code is formatted with `rustfmt` - [ ] No useless or dead code (if applicable) - [ ] Code is easy to understand - [ ] Doc comments are used for all functions, enums, structs, and fields (where appropriate) - [ ] All tests pass - [ ] Performance has not regressed (assuming change was not to fix a bug) - [ ] Version number has been updated in `helix-cli/Cargo.toml` and `helixdb/Cargo.toml` - [ ] Lines are kept under 100 characters where possible - [ ] Code is good ## Additional Notes <!-- Add any additional information that would be helpful for reviewers -->
…ing weird issue with reqwest for embeddings (#300) ## Description <!-- Provide a brief description of the changes in this PR --> impr + fix/improving order by so traversals can come after order, fixing weird issue with reqwest for embeddings ## Related Issues <!-- Link to any related issues using #issue_number --> Closes # ## Checklist when merging to main <!-- Mark items with "x" when completed --> - [ ] No compiler warnings (if applicable) - [ ] Code is formatted with `rustfmt` - [ ] No useless or dead code (if applicable) - [ ] Code is easy to understand - [ ] Doc comments are used for all functions, enums, structs, and fields (where appropriate) - [ ] All tests pass - [ ] Performance has not regressed (assuming change was not to fix a bug) - [ ] Version number has been updated in `helix-cli/Cargo.toml` and `helixdb/Cargo.toml` - [ ] Lines are kept under 100 characters where possible - [ ] Code is good ## Additional Notes <!-- Add any additional information that would be helpful for reviewers -->
## Description <!-- Provide a brief description of the changes in this PR --> ## Related Issues <!-- Link to any related issues using #issue_number --> Closes # ## Checklist when merging to main <!-- Mark items with "x" when completed --> - [ ] No compiler warnings (if applicable) - [ ] Code is formatted with `rustfmt` - [ ] No useless or dead code (if applicable) - [ ] Code is easy to understand - [ ] Doc comments are used for all functions, enums, structs, and fields (where appropriate) - [ ] All tests pass - [ ] Performance has not regressed (assuming change was not to fix a bug) - [ ] Version number has been updated in `helix-cli/Cargo.toml` and `helixdb/Cargo.toml` - [ ] Lines are kept under 100 characters where possible - [ ] Code is good ## Additional Notes <!-- Add any additional information that would be helpful for reviewers -->
There was a problem hiding this comment.
Pull Request Overview
This PR removes the "json" feature from the reqwest dependency to resolve compatibility issues with sonic_rs JSON library. The change addresses conflicts that occur when both serde_json (used by reqwest's json feature) and sonic_rs are used together.
Key Changes
- Remove "json" feature from reqwest dependency configuration while keeping "blocking" feature
| "json", | ||
| "blocking", | ||
| ], optional = true } | ||
| reqwest = { version = "0.12.15", features = ["blocking"], optional = true } |
There was a problem hiding this comment.
Removing the 'json' feature from reqwest may break existing code that relies on reqwest's built-in JSON serialization/deserialization methods like .json() on requests and responses. Consider adding sonic_rs as an explicit dependency if it's the intended JSON library replacement, or document the migration path for affected code.
Suggested change
| reqwest = { version = "0.12.15", features = ["blocking"], optional = true } | |
| reqwest = { version = "0.12.15", features = ["blocking", "json"], optional = true } |
Copilot uses AI. Check for mistakes.
…key parsing for embeddings (#310) ## Description <!-- Provide a brief description of the changes in this PR --> ## Related Issues <!-- Link to any related issues using #issue_number --> Closes # ## Checklist when merging to main <!-- Mark items with "x" when completed --> - [ ] No compiler warnings (if applicable) - [ ] Code is formatted with `rustfmt` - [ ] No useless or dead code (if applicable) - [ ] Code is easy to understand - [ ] Doc comments are used for all functions, enums, structs, and fields (where appropriate) - [ ] All tests pass - [ ] Performance has not regressed (assuming change was not to fix a bug) - [ ] Version number has been updated in `helix-cli/Cargo.toml` and `helixdb/Cargo.toml` - [ ] Lines are kept under 100 characters where possible - [ ] Code is good ## Additional Notes <!-- Add any additional information that would be helpful for reviewers -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reqwest uses serde_json for its json feature, which causes errors when used in conjunction with sonic_rs
Related Issues
Closes #
Checklist when merging to main
rustfmthelix-cli/Cargo.tomlandhelixdb/Cargo.tomlAdditional Notes