Skip to content

remove json feature from reqwest #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

remove json feature from reqwest #304

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8fa932b
impr/fixing hql bugs and refactoring analyzer (#257)
xav-db Jul 18, 2025
4403129
bug/fixing issue with update traversal step and reading config (#259)
xav-db Jul 19, 2025
7e0270d
removing queries (#260)
xav-db Jul 19, 2025
eff58f8
impr + bugs/soft deleting vectors, HQL test fixes, HQL ID prop access…
xav-db Jul 20, 2025
f3f7f35
fix + impr/rewritten server infra, fixed issues with cli, more bug fi…
xav-db Jul 23, 2025
472c376
impr + fix/removing warnings, adding clippy, improving cli, adding in…
xav-db Jul 27, 2025
9dd2aa6
impr + fix/implementing mcp nested filtering, env sourcing and order …
xav-db Jul 30, 2025
636ce93
impr + fix/improving order by so traversals can come after order, fix…
xav-db Jul 30, 2025
c075173
updating versions (#301)
xav-db Jul 30, 2025
b97da96
remove json feature from reqwest
RaphaelDarley Jul 31, 2025
ff2953c
impr + fix/implementing reading secondary from schema and fixing api …
xav-db Jul 31, 2025
9fe6347
Merge remote-tracking branch 'upstream/main' into remove-serde_json
RaphaelDarley Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions helix-db/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,7 @@ pest = { version = "2.7", optional = true }
pest_derive = { version = "2.7", optional = true }

# Embedding dependencies
reqwest = { version = "0.12.15", features = [
"json",
"blocking",
], optional = true }
reqwest = { version = "0.12.15", features = ["blocking"], optional = true }
Copy link
Preview

Copilot AI Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the 'json' feature from reqwest may break existing code that relies on reqwest's built-in JSON serialization/deserialization methods like .json() on requests and responses. Consider adding sonic_rs as an explicit dependency if it's the intended JSON library replacement, or document the migration path for affected code.

Suggested change
reqwest = { version = "0.12.15", features = ["blocking"], optional = true }
reqwest = { version = "0.12.15", features = ["blocking", "json"], optional = true }

Copilot uses AI. Check for mistakes.

url = { version = "2.5", optional = true }
tokio-util = { version = "0.7.15", features = ["compat"] }
axum = "0.8.4"
Expand Down
Loading