fix(cli) Fixing helix push #853
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greptile Overview
Greptile Summary
Fixed container name display format and improved container existence checking in the CLI, and resolved HQL codegen failure for WHERE clauses with traversal steps before property access.
Key Changes
helix_{project}_{instance}tohelix-{project}-{instance}to match actual Docker container naming convention (hyphens instead of underscores)instance_existsto use centralizedcontainer_namemethod and exact string matching instead ofcontains, improving accuracy_::ToN::ID::EQ(id)and_::ToN::{age}::EQ(age)that previously caused Rust codegen failuresThe changes are well-structured and include proper test coverage for the codegen fix.
Important Files Changed
Sequence Diagram
sequenceDiagram participant User participant CLI as Helix CLI participant Docker as Docker/Podman participant Compiler as HelixC Codegen Note over User,Compiler: CLI Container Naming Fix User->>CLI: helix push CLI->>CLI: compose_project_name(instance_name) Note right of CLI: Returns "helix-{project}-{instance}" CLI->>CLI: container_name(instance_name) Note right of CLI: Returns "helix-{project}-{instance}_app" CLI->>Docker: Check container exists Docker-->>CLI: Container status CLI->>CLI: Display container info Note right of CLI: Now shows "helix-{project}-{instance}" (fixed from "helix_{project}_{instance}") Note over User,Compiler: HQL Traversal Property Access Fix (#847) User->>Compiler: Compile WHERE(_::ToN::ID::EQ(id)) Compiler->>Compiler: Parse traversal steps Note right of Compiler: Detects pattern: [ToN] + [ID] + [EQ] Compiler->>Compiler: Generate optimized filter_ref Note right of Compiler: Creates traversal chain + property access Compiler-->>User: Valid Rust code generated