Skip to content

fix(cli) Fixing helix push #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xav-db merged 1 commit into from
Feb 6, 2026
Merged

fix(cli) Fixing helix push #853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helix-cli/src/commands/push.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ async fn push_local_instance(
("Local URL", &format!("http://localhost:{actual_port}")),
(
"Container",
&format!("helix_{project_name}_{instance_name}"),
&format!("helix-{project_name}-{instance_name}"),
),
(
"Data volume",
Expand Down
4 changes: 2 additions & 2 deletions helix-cli/src/docker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,11 +707,11 @@ networks:
/// Check if an instance container exists (running or stopped)
pub fn instance_exists(&self, instance_name: &str) -> Result<bool> {
let statuses = self.get_project_status()?;
let target_container_name = format!("helix_{instance_name}_app");
let target_container_name = self.container_name(instance_name);

Ok(statuses
.iter()
.any(|status| status.container_name.contains(&target_container_name)))
.any(|status| status.container_name == target_container_name))
}

/// Get status of all Docker/Podman containers for this project
Expand Down
Loading