Put the current ROBOT profile in the templates directory.#1187
Merged
Put the current ROBOT profile in the templates directory.#1187
Conversation
For now, when building the image, we download the ROBOT report profile for the current version of ROBOT (the version used in the ODK) and put it in /tools/robot_report_profile.txt. We do that so that we can check, as part of the standard workflow, whether the custom profile that the project may be using is not lacking any new tests that are available in the current version of ROBOT (see #998). Here, we simply move the location of the profile file within the image, from /tools/robot_report_profile.txt to /tools/templates/src/ontology/profile.txt This does not change how the check mentioned above works (we just update the path involved in that check), but this will have the benefit of automatically installing the ROBOT profile when seeding a repository, since the file is now within the template directory used by the seeding system. Therefore, we can remove the 'src/ontology/profile.txt' block from the dynamic template pack (which needed to be manually updated by us whenever we updated ROBOT -- something I don't think we have really been doing). But we do not want to _always_ install this profile.txt file in a seeded repository -- we only need to do that when the use of a custom profile is enabled in the configuration (that was the reason why the profile was part of the dynamic template pack). To avoid installing the file when a custom profile is _not_ enabled, we use the recently introduced per-template policies system: we set the policy for the 'src/ontology/profile.txt' template to NEVER if a custom profile is not enabled. closes #999
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, when building the image, we download the ROBOT report profile for the current version of ROBOT (the version used in the ODK) and put it in
/tools/robot_report_profile.txt. We do that so that we can check, as part of the standard workflow, whether the custom profile that the project may be using is not lacking any new tests that are available in the current version of ROBOT (see #998).Here, we simply move the location of the profile file within the image, from
/tools/robot_report_profile.txtto/tools/templates/src/ontology/profile.txt.This does not change how the check mentioned above works (we just update the path involved in that check), but this will have the benefit of automatically installing the ROBOT profile when seeding a repository, since the file is now within the template directory used by the seeding system.
Therefore, we can remove the
src/ontology/profile.txtblock from the dynamic template pack (which needed to be manually updated by us whenever we updated ROBOT – something I don't think we have really been doing).But we do not want to always install this
profile.txtfile in a seeded repository – we only need to do that when the use of a custom profile is enabled in the configuration (that was the reason why the profile was part of the dynamic template pack). To avoid installing the file when a custom profile is not enabled, we use the recently introduced per-template policies system: we set the policy for thesrc/ontology/profile.txttemplate to NEVER if a custom profile is not enabled.closes #999