Fix @AutoService classes not being loaded at runtime when using JDK23+ for compilation

[pdurbin]

What this PR does / why we need it:

Both @JR-1991 and @ofahimIQSS have had trouble getting the containerized environment working because they had a version of Java that was too new. (For Jan it was Java 23, see discussion.) They're using our dev quickstart: mvn -Pct clean package docker:run

Special notes for your reviewer:
None. Merely adding the missing compile plugin config bits according to the auto-services docs.

Suggestions on how to test this:

1. Use SDKMAN to have multiple JDK versions at the ready.
2. Install JDK 17, 21, and 23
3. With all these versions run mvn clean compile. Confirm all the necessary (3) files are present at target/classes/META-INF/services
4. If you have Docker on your machine, you can use mvn -Pct clean package docker:run and JDK 23 to verify it works now.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Nope

Is there a release notes update needed for this change?:
Nope

Additional documentation:
None

We've been using the maven-enforcer-plugin plugin and its requireJavaVersion rule since d6c3f7a but it's set for "Java 17 or newer".

In this pull request, I'm suggesting we set it to "Java 17 and not newer". See also "Version Range Specification" at https://maven.apache.org/enforcer/enforcer-rules/versionRanges.html

I'm also simplifying the syntax because I don't think we need .0 in there.

Here's how the output looks (as of this pull request) when you try to use a version of Java that's too new:

[ERROR] Detected JDK version 21.0.4 (JAVA_HOME=/Users/PDurbin/.sdkman/candidates/java/21.0.4-tem) is not in the allowed range [17,18].

[coveralls]

coverage: 23.141% (+0.07%) from 23.071%
when pulling c27c57b on enforce-java-17
into ac30566 on develop.

[poikilotherm]

Trying to reproduce here. (Without any enforcing rules, using a clean build with our current base images)

1. When using Java 21 (Temurin LTS), I cannot reproduce the issue. Works!
2. When using Java 23 (Temurin 23.0.2), I get the "No default PID provider configured" message and the failing config check makes the deployment fail.

The problem was us having missed to add the auto-services annotation processor to the Maven compile plugin. See auto-services docs. Because of this mistake, the META-INF/services files were not generated, disabling the ServiceLoader to pick up the classes at runtime. Simple fix, ensuring future compatibility! Would also have affected the Exporter plugins as same logic applies.

[poikilotherm]

@pdurbin this is ready for review and a very simple fix. IMHO this can be fast tracked, as it doesn't affect any code - just making sure the annotation processor works as intended. I tested this with JDK 17, 21 and 23, using mvn -Pct clean package docker:run and looking at target/classes/META-INF/services folder to contain the necessary files and no PID provider not found messages from the log output.

[poikilotherm]

The failing image builds are probably Docker Hub hickups. "error pulling image configuration: image config verification failed for digest" is not even remotely related to the changes of the build configuration (compile phase, not package phase).

[pdurbin]

I tested with Java 21.0.4-tem and it worked fine. Thanks, @poikilotherm . This is really your PR now and I'd approve it if I could! 😄

I also tweaked the docs to say, "The recommended version is Java 17 because it's the version we test with."

And in the dev guide I linked to the PR where we upgraded to Java 17:

• Upgrade to Java 17 #9764

[github-actions]

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:enforce-java-17

ghcr.io/gdcc/configbaker:enforce-java-17

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

[ofahimIQSS]

All tests passed successfully across JDK 17, 21, and 23. No issues found with service loader files or runtime behavior. The PR fix works as intended.

Verified following JDKs (17.0.15-amzn, 21.0.7-amzn, 23.0.2-amzn), ensured that files were present.
edu.harvard.iq.dataverse.pidproviders.PidProviderFactory
org.eclipse.microprofile.config.spi.ConfigSourceProvider
io.gdcc.spi.export.Exporter

Merging.