Skip to content

Fix @AutoService classes not being loaded at runtime when using JDK23+ for compilation #11487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ofahimIQSS merged 4 commits into from
Jun 4, 2025
Merged

Fix @AutoService classes not being loaded at runtime when using JDK23+ for compilation #11487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
952617e
enforce Java 17 (no higher)
pdurbin May 12, 2025
28d288b
Revert "enforce Java 17 (no higher)"
poikilotherm Jun 4, 2025
048c241
refactor(build): centralize `auto-service` version and configure anno…
poikilotherm Jun 4, 2025
c27c57b
recommend Java 17 because we test with it #11487
pdurbin Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/sphinx-guides/source/developers/dev-environment.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Detailed Steps
Install Java
~~~~~~~~~~~~

The Dataverse Software requires Java 17.
The recommended version is Java 17 because it's the version we test with. See https://github.com/IQSS/dataverse/pull/9764.

On Mac and Windows, we suggest using `SDKMAN <https://sdkman.io>`_ to install Temurin (Eclipe's name for its OpenJDK distribution). Type ``sdk install java 17`` and then hit the "tab" key until you get to a version that ends with ``-tem`` and then hit enter.

Expand Down
2 changes: 1 addition & 1 deletion doc/sphinx-guides/source/installation/prerequisites.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ We assume you plan to run your Dataverse installation on Linux and we recommend
Java
----

The Dataverse Software requires Java SE 17 (or higher).
The recommended version is Java 17 because it's the version we test with.

Installing Java
===============
Expand Down
11 changes: 10 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@

<reload4j.version>1.2.18.4</reload4j.version>
<flyway.version>10.19.0</flyway.version>
<auto-service.version>1.1.1</auto-service.version>
<jhove.version>1.20.1</jhove.version>
<poi.version>5.4.0</poi.version>
<tika.version>2.9.2</tika.version>
Expand Down Expand Up @@ -526,7 +527,7 @@
<dependency>
<groupId>com.google.auto.service</groupId>
<artifactId>auto-service</artifactId>
<version>1.1.1</version>
<version>${auto-service.version}</version>
<optional>true</optional>
<type>jar</type>
</dependency>
Expand Down Expand Up @@ -831,6 +832,14 @@
<release>${target.java.version}</release>
<!-- for use with `mvn -DcompilerArgument=-Xlint:unchecked compile` -->
<compilerArgument>${compilerArgument}</compilerArgument>
<!-- Ensure the annotation processor for @AutoService is picked up. Especially important as of JDK 23 -->
<annotationProcessorPaths>
<path>
<groupId>com.google.auto.service</groupId>
<artifactId>auto-service</artifactId>
<version>${auto-service.version}</version>
</path>
</annotationProcessorPaths>
</configuration>
</plugin>
<plugin>
Expand Down