adding type and dvObject to dataverse featured items#11499
Merged
ofahimIQSS merged 28 commits intodevelopfrom Jun 3, 2025
Merged
adding type and dvObject to dataverse featured items#11499ofahimIQSS merged 28 commits intodevelopfrom
ofahimIQSS merged 28 commits intodevelopfrom
Conversation
github-actions
bot
added
FY25 Sprint 22
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/main/java/edu/harvard/iq/dataverse/dataverse/featured/DataverseFeaturedItem.java
Outdated
Show resolved
Hide resolved
stevenwinship
added
Type: Feature
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
GPortas
previously approved these changes
Jun 3, 2025
Contributor
GPortas
left a comment
GPortas
left a comment
There was a problem hiding this comment.
I am almost ready to approve. Thanks.
| } | ||
|
|
||
| @NotNull | ||
| protected DvObject findDvoOrDie(@NotNull final String dvIdtf, String type) throws WrappedResponse { |
Contributor
There was a problem hiding this comment.
This method mixes two responsibilities: searching for a dvObject and validating the related featured item type. I'm not asking you to refactor it right now, but at least, please rename the method. findDvoOrDie sounds too generic — it's specific to featured items and could easily be accidentally used outside the scope of featured items.
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
This comment has been minimized.
This comment has been minimized.
GPortas
approved these changes
Jun 3, 2025
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
Contributor
|
Tests passed - merging PR |
github-project-automation
bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
This was referenced Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: New feature request to allow Featured Items to include collections(dataverse), datasets, and datafile.
Which issue(s) this PR closes: #11414
Special notes for your reviewer:
Suggestions on how to test this: See IT Tests
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: Included
Additional documentation: