Skip to content

Conversation

@sekmiller
Copy link
Contributor

What this PR does / why we need it: Gets counts by type of dvObject for pages beyond the first page

Which issue(s) this PR closes:

Special notes for your reviewer:
Note in code references speed as reason for not implementing in original. With a small DB - not easy to see a time saving?

Suggestions on how to test this: see original ticket. access search api with show_type_counts=true and &start=10 (>0)

Does this PR introduce a user interface change? If mockups are available, please link/include them here: no

Is there a release notes update needed for this change?: no

Additional documentation: none

@sekmiller sekmiller added this to the 6.7 milestone Jun 4, 2025
@sekmiller sekmiller added the Size: 3 A percentage of a sprint. 2.1 hours. label Jun 4, 2025
@github-actions github-actions bot added GREI Re-arch Issues related to the GREI Dataverse rearchitecture Original size: 3 SPA These changes are required for the Dataverse SPA Type: Bug a defect labels Jun 4, 2025
@sekmiller sekmiller moved this to Ready for Review ⏩ in IQSS Dataverse Project Jun 4, 2025
@github-actions
Copy link

github-actions bot commented Jun 4, 2025

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:11542-get-file-count-pg-2
ghcr.io/gdcc/configbaker:11542-get-file-count-pg-2

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@coveralls
Copy link

Coverage Status

coverage: 23.146%. remained the same
when pulling 6a64c6d on 11542-get-file-count-pg-2
into 1d03a2f on develop.

@g-saracca
Copy link
Contributor

@sekmiller I think we agree that it was ok to close this one right?

@sekmiller
Copy link
Contributor Author

decided not to take this approach

@sekmiller sekmiller closed this Jun 6, 2025
@sekmiller sekmiller deleted the 11542-get-file-count-pg-2 branch June 6, 2025 18:27
@sekmiller sekmiller restored the 11542-get-file-count-pg-2 branch June 17, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GREI Re-arch Issues related to the GREI Dataverse rearchitecture Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA These changes are required for the Dataverse SPA Type: Bug a defect

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search API - Count per object after page Start>0

4 participants