Skip to content

#11542 get all type counts after first page #11554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sekmiller wants to merge 1 commit into from
Closed

#11542 get all type counts after first page #11554

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/main/java/edu/harvard/iq/dataverse/api/Search.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,9 @@ public Response search(
if (!types.isEmpty()) {
// Query to get the totals if needed.
// Only needed if the list of types doesn't include all types since missing types will default to count of 0
// Only get the totals for the first page (paginationStart == 0) for speed
if (showTypeCounts && types.size() < objectTypeCountsMap.size() && paginationStart == 0) {
// Only get the totals for the first page (paginationStart == 0) for speed removing paginationStart == 0 for 11542 SEK 06/04/25
// how slow is it to leave pagination start == 0 out? SEK 06/04/2025? ref11542
if (showTypeCounts && types.size() < objectTypeCountsMap.size()) {
List<String> totalFilterQueries = new ArrayList<>();
totalFilterQueries.addAll(filterQueries);
totalFilterQueries.add(SearchFields.TYPE + allTypes);
Expand Down