Skip to content

Conversation

@ofahimIQSS
Copy link
Contributor

Reverts #11534

@pdurbin pdurbin moved this to In Review 🔎 in IQSS Dataverse Project Jul 23, 2025
@pdurbin pdurbin self-assigned this Jul 23, 2025
@pdurbin
Copy link
Member

pdurbin commented Jul 23, 2025

I'll wait until the automated testing passes before sending this to "ready for QA" but we are reverting this PR because PR #11534 breaks existing databases. Let's try again with a new PR but next time it should have a Flyway script like the one in #8174 that updates the database with new permission bits.

This: https://github.com/GlobalDataverseCommunityConsortium/dataverse/blob/6c609c408e483e3e510a15413c60cade9276b60d/src/main/resources/db/migration/V5.8.0.1__8109-add-manage-files-permission.sql

@coveralls
Copy link

Coverage Status

coverage: 23.223% (-0.002%) from 23.225%
when pulling a4ea861 on revert-11534-feat/link-permission
into c856b07 on develop.

@github-actions
Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:revert-11534-feat-link-permission
ghcr.io/gdcc/configbaker:revert-11534-feat-link-permission

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API tests are passing. They took 18 minutes to run. https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-11682/1/testReport/

Approved.

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Jul 24, 2025
@pdurbin pdurbin removed their assignment Jul 24, 2025
@ofahimIQSS ofahimIQSS self-assigned this Jul 24, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Jul 24, 2025
@ofahimIQSS
Copy link
Contributor Author

Merging - looks good.

@ofahimIQSS ofahimIQSS merged commit 07a9647 into develop Jul 24, 2025
19 checks passed
@github-project-automation github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Jul 24, 2025
@ofahimIQSS ofahimIQSS deleted the revert-11534-feat/link-permission branch July 24, 2025 14:13
@ofahimIQSS ofahimIQSS removed their assignment Jul 24, 2025
@pdurbin pdurbin added this to the 6.8 milestone Jul 24, 2025
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Jul 24, 2025
@cmbz cmbz added the FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) label Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27)

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

5 participants