Skip to content

Conversation

@vera
Copy link
Contributor

@vera vera commented May 28, 2025

What this PR does / why we need it:

Linking or unlinking a dataset or dataverse now requires the new "Link Dataset/Dataverse" permission.
Previously, this action was covered by the "Publish Dataset/Dataverse" permission.
Linking and publishing permissions can now be granted separately, allowing for more fine-grained access control.

Which issue(s) this PR closes:

/

Special notes for your reviewer:

/

Suggestions on how to test this:

I've extended an existing test which can be run with mvn test -Dtest="DatasetsIT#testCreateDeleteDatasetLink" to check that datasets cannot be linked/unlinked unless you have the curator role, which has been altered to include the new link permissions.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

/

Is there a release notes update needed for this change?:

I've added a short release note.

Additional documentation:

/

@pdurbin pdurbin moved this to Ready for Triage in IQSS Dataverse Project May 28, 2025
@ofahimIQSS ofahimIQSS added the Size: 10 A percentage of a sprint. 7 hours. label Jun 3, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for Triage to Ready for Review ⏩ in IQSS Dataverse Project Jun 3, 2025
@cmbz cmbz added the FY25 Sprint 25 FY25 Sprint 25 (2025-06-04 - 2025-06-18) label Jun 4, 2025
@cmbz cmbz added the FY25 Sprint 26 FY25 Sprint 26 (2025-06-18 - 2025-07-02) label Jun 19, 2025
@cmbz cmbz added the FY26 Sprint 1 FY26 Sprint 1 (2025-07-02 - 2025-07-16) label Jul 2, 2025
@stevenwinship stevenwinship self-assigned this Jul 14, 2025
@stevenwinship stevenwinship moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Jul 14, 2025
@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Jul 14, 2025
@stevenwinship stevenwinship removed their assignment Jul 14, 2025
@cmbz cmbz added the FY26 Sprint 2 FY26 Sprint 2 (2025-07-16 - 2025-07-30) label Jul 17, 2025
@ofahimIQSS ofahimIQSS self-assigned this Jul 22, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Jul 22, 2025
@ofahimIQSS
Copy link
Contributor

tests are passing, looks good to me - merging.

@ofahimIQSS ofahimIQSS merged commit f677806 into IQSS:develop Jul 23, 2025
19 checks passed
@github-project-automation github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Jul 23, 2025
@ofahimIQSS ofahimIQSS removed their assignment Jul 23, 2025
@pdurbin pdurbin added this to the 6.8 milestone Jul 23, 2025
@pdurbin
Copy link
Member

pdurbin commented Jul 23, 2025

We need to revert this. Here's the PR to do so:

@pdurbin
Copy link
Member

pdurbin commented Jul 24, 2025

@vera as mentioned above, we had to revert this PR. As written, it breaks existing databases.

I assume you're still interested in this functionality. Would you be able to create a new PR (and an issue first, if you don't mind) that includes a Flyway script like the one in #8174 that updates the database with new permission bits.

This: https://github.com/GlobalDataverseCommunityConsortium/dataverse/blob/6c609c408e483e3e510a15413c60cade9276b60d/src/main/resources/db/migration/V5.8.0.1__8109-add-manage-files-permission.sql

That way, existing databases will get the updated permission bits, thanks to the Flyway script. We can help with the Flyway script if you need it!

@pdurbin
Copy link
Member

pdurbin commented Jul 28, 2025

@vera created a follow up issue here (thanks!):

@vera
Copy link
Contributor Author

vera commented Jul 29, 2025

I've resubmitted the PR with a Flyway migration script here: #11691

Sorry, I don't know how I missed the big comment in Permissions.java. Now I know better for next time. 😄

@pdurbin
Copy link
Member

pdurbin commented Jul 29, 2025

@vera thanks! Don't worry, a number of us missed it! Thanks for the new PR! ❤️

@cmbz cmbz added the FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) label Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY25 Sprint 25 FY25 Sprint 25 (2025-06-04 - 2025-06-18) FY25 Sprint 26 FY25 Sprint 26 (2025-06-18 - 2025-07-02) FY26 Sprint 1 FY26 Sprint 1 (2025-07-02 - 2025-07-16) FY26 Sprint 2 FY26 Sprint 2 (2025-07-16 - 2025-07-30) FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) Size: 10 A percentage of a sprint. 7 hours.

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

5 participants