Check opis on GHA #1782
Merged
Check opis on GHA #1782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tom-Willemsen
force-pushed
the
lint_more
branch
6 times, most recently
from
4ed5133 to
eee9160
Compare
Tom-Willemsen
force-pushed
the
lint_more
branch
5 times, most recently
from
92fb08e to
bdab432
Compare
Tom-Willemsen
force-pushed
the
lint_more
branch
from
bdab432 to
8335177
Compare
rerpha
reviewed
Mar 17, 2025
| on: [pull_request] | ||
| jobs: | ||
| check-opi-format: | ||
| runs-on: "windows-latest" |
Contributor
There was a problem hiding this comment.
does this need windows? i couldn't see anything in https://github.com/ISISComputingGroup/ibex_gui/blob/master/base/uk.ac.stfc.isis.ibex.opis/check_opi_format.py that was hardcoded to a windows path other than in the ignored paths
Member
Author
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
Probably test could be changed if we prefer... This was just the low-cost route.
rerpha
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can do various "pre-flight" checks/lints in GHA, without waiting for a full maven build to go through on the slowest build server. This makes the feedback loop much faster.
Migrating the full build / deploy process is harder & I'm declaring that out-of-scope