Skip to content

Check opis on GHA #1782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rerpha merged 2 commits into from
Mar 17, 2025
Merged

Check opis on GHA #1782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8335177
Check opis on GHA
Tom-Willemsen Mar 16, 2025
ffee629
Add dummy widgets
Tom-Willemsen Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
version: 2
updates:
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "daily"
50 changes: 50 additions & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,56 @@
name: lint
on: [pull_request]
jobs:
check-opi-format:
runs-on: "windows-latest"
Copy link
Contributor

@rerpha rerpha Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need windows? i couldn't see anything in https://github.com/ISISComputingGroup/ibex_gui/blob/master/base/uk.ac.stfc.isis.ibex.opis/check_opi_format.py that was hardcoded to a windows path other than in the ignored paths

Copy link
Member Author

@Tom-Willemsen Tom-Willemsen Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ibex_gui/base/uk.ac.stfc.isis.ibex.opis/check_opi_info.py

Line 2 in 3e3b46a

import win32api

Copy link
Member Author

@Tom-Willemsen Tom-Willemsen Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably test could be changed if we prefer... This was just the low-cost route.

Copy link
Contributor

@rerpha rerpha Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meh

steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: '3.11'
- name: OPI checker dependencies
run: python -m pip install -r base/uk.ac.stfc.isis.ibex.opis/requirements.txt
- name: Run OPI checker
run: python base/uk.ac.stfc.isis.ibex.opis/check_opi_format.py -strict -directory base/uk.ac.stfc.isis.ibex.opis
- name: Validate OPIs
run: python base/uk.ac.stfc.isis.ibex.opis/validate_opis.py

check-build:
runs-on: "ubuntu-latest"
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: '3.11'
- name: Run check_build
working-directory: ./build
run: python check_build.py ../base

scriptgenerator-tests:
runs-on: "ubuntu-latest"
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: '3.11'
- name: Install dependencies
run: python -m pip install -r ./base/uk.ac.stfc.isis.ibex.scriptgenerator/python_support/requirements.txt
- name: Run scriptgenerator tests
working-directory: ./base/uk.ac.stfc.isis.ibex.scriptgenerator/python_support
run: python -m unittest discover

checkstyle:
runs-on: "ubuntu-latest"
steps:
- uses: actions/checkout@v4
- uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: '21'
- name: checkstyle
working-directory: ./base/uk.ac.stfc.isis.ibex.client.tycho.parent
run: mvn checkstyle:check

code-ql:
strategy:
matrix:
Expand Down
4 changes: 4 additions & 0 deletions base/uk.ac.stfc.isis.ibex.opis/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
lxml
pyhamcrest
pywin32
xmlrunner
Loading
Loading