Skip to content

Conversation

@YuryHrytsuk
Copy link
Collaborator

@YuryHrytsuk YuryHrytsuk commented Jul 15, 2025

What do these changes do?

Creates a single authneticated dockerhub registry in Portainer. With this registry, private docker images can be pulled.

Bonus:

  • Add reusable $(WAIT_FOR_IT) target that calls https://github.com/wait4x/wait4x and supports many protocols
  • Extend install target (requirements.txt file's path can be configured)

Manual testing

  • Check that portainer can pull private images on PROD deployments

Related issue/s

Related PR/s

Checklist

  • I tested and it works

Creates a single authneticated dockerhub registry that lets pulling
private images (i.e. updating service's image (that is private) in portainer shall work now)

* closes ITISFoundation#1089
@YuryHrytsuk YuryHrytsuk mentioned this pull request Jul 15, 2025
1 task
@YuryHrytsuk YuryHrytsuk self-assigned this Jul 15, 2025
@YuryHrytsuk YuryHrytsuk added the t:enhancement New feature or request label Jul 15, 2025
@YuryHrytsuk YuryHrytsuk added this to the Engage milestone Jul 15, 2025
@YuryHrytsuk YuryHrytsuk marked this pull request as ready for review July 15, 2025 14:50
@YuryHrytsuk YuryHrytsuk requested a review from mrnicegyu11 as a code owner July 15, 2025 14:50
@YuryHrytsuk YuryHrytsuk changed the title Add portainer registry configuration Add portainer registry configuration 🚨 Jul 15, 2025
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good, approved!

@YuryHrytsuk YuryHrytsuk merged commit 19d1412 into ITISFoundation:main Jul 16, 2025
3 checks passed
YuryHrytsuk added a commit to YuryHrytsuk/osparc-ops-environments that referenced this pull request Jul 17, 2025
@YuryHrytsuk YuryHrytsuk mentioned this pull request Jul 17, 2025
1 task
YuryHrytsuk added a commit that referenced this pull request Jul 17, 2025
* Automatically configure registry in portainer

Creates a single authneticated dockerhub registry that lets pulling
private images (i.e. updating service's image (that is private) in portainer shall work now)

* closes #1089

* Update

* Imrpove wait for it installation

* Fix portainer makefile wrong options

#1125

* fix

* spacing
YuryHrytsuk added a commit that referenced this pull request Jul 17, 2025
* Automatically configure registry in portainer

Creates a single authneticated dockerhub registry that lets pulling
private images (i.e. updating service's image (that is private) in portainer shall work now)

* closes #1089

* Update

* Imrpove wait for it installation

* Fix portainer makefile wrong options

#1125

* fix

* spacing

* Restrict metabase user to set of tables

* closes #1113

* configuration

* Add readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Portainer cannot start service with private images

2 participants