- 
                Notifications
    
You must be signed in to change notification settings  - Fork 32
 
🐛🎨 Fixes unhandled config error and new log helpers for better troubleshotting #6432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          Codecov ReportAttention: Patch coverage is  
 Additional details and impacted files@@            Coverage Diff            @@
##           master   #6432      +/-   ##
=========================================
+ Coverage    84.5%   88.0%    +3.4%     
=========================================
  Files          10    1375    +1365     
  Lines         214   59436   +59222     
  Branches       25    1553    +1528     
=========================================
+ Hits          181   52339   +52158     
- Misses         23    6846    +6823     
- Partials       10     251     +241     
 Flags with carried forward coverage won't be shown. Click here to find out more. 
  | 
    
a767017    to
    5f65734      
    Compare
  
    5f65734    to
    aa33995      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good :--)
          
 | 
    



What do these changes do?
This PR provides some helpers for better error-handling and diagnostics. This is applicable to any type of excption but in this case, we apply to a common unhandled error we found when a platform product is partially configured and the
groups_extra_propertiesconfiguration is missing.MissingGroupExtraPropertiesForProductErrorerror in the web-server_handle_users_exceptionswe handle it in the users rest API handlersThere we handle as
An exception is handled at the rest-handler level. This exception cannot be resolved and we need to send a comprehensive message to the front-end user as well as log sufficient information in the server for troubleshooting. The handling of the exception has the following steps
create_troubleshotting_log_messageto produce a rich log messagelog.exceptionincluding extrasRelated issue/s
How to test
Dev-ops checklist
None