♻️🔨 Unexpected mypy upgrade revealed configuration and code failures

[pcrespov]

What do these changes do?

The issue was caused by our CI pipeline not using a pinned version of mypy; instead, it was always fetching the latest version. This happened because requirements/ci.txt did not include requirements/tools.txt, which specifies the version for mypy.

As a result, mypy was updated between the CI passing for this PR and its merge into the master branch (commit da15add).

The new version of mypy introduced additional type checks that uncovered issues in some parts of the code. Specifically, we had to make further changes to the section handling invoice attachments in emails to resolve these newly identified issues.

Highlights

• ♻️ payments service:
  • Proper attachment and better error handling to invoice attachment.
  • Adapts tests
  • @matusdrobuliak66 please pay special attention to the changes i did of your code in
    - services/payments/src/simcore_service_payments/services/notifier_email.py
    - services/payments/tests/unit/test_services_notifier_email.py
• ♻️ ensures create_troubleshotting_log_message does not raise
• 🔨 uses uv run to run script

Related issue/s

• Fixes typecheck in CI pipelines

How to test

Dev-ops checklist

NOne

[codecov]

Codecov Report

Attention: Patch coverage is 90.69767% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.1%. Comparing base (cafbf96) to head (7b3df84).
Report is 628 commits behind head on master.

Files with missing lines	Patch %	Lines
...imcore_service_payments/services/notifier_email.py	91.6%	3 Missing ⚠️
...models_library/utils/_original_fastapi_encoders.py	0.0%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #6527      +/-   ##
=========================================
+ Coverage    84.5%   88.1%    +3.5%     
=========================================
  Files          10    1548    +1538     
  Lines         214   63351   +63137     
  Branches       25    2059    +2034     
=========================================
+ Hits          181   55845   +55664     
- Misses         23    7188    +7165     
- Partials       10     318     +308     

Flag	Coverage Δ
integrationtests	64.7% <ø> (?)
unittests	86.1% <90.6%> (+1.5%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...es/service-library/src/servicelib/logging_utils.py	77.8% <100.0%> (ø)
packages/service-library/src/servicelib/utils.py	91.6% <100.0%> (ø)
...es/service-library/src/servicelib/utils_secrets.py	92.3% <100.0%> (ø)
...models_library/utils/_original_fastapi_encoders.py	51.2% <0.0%> (ø)
...imcore_service_payments/services/notifier_email.py	95.1% <91.6%> (ø)

... and 1493 files with indirect coverage changes

[matusdrobuliak66]

👍

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[jsaq007]

👍