Skip to content

♻️🔨 Unexpected mypy upgrade revealed configuration and code failures #6527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Oct 15, 2024
Merged

♻️🔨 Unexpected mypy upgrade revealed configuration and code failures #6527

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
825c684
uses uv run to run script
pcrespov Oct 14, 2024
b8128b0
disables mypy from this file
pcrespov Oct 14, 2024
1ee57b5
uv in locust
pcrespov Oct 14, 2024
ed0fdf9
undo
pcrespov Oct 14, 2024
aa7a585
arg-type
pcrespov Oct 14, 2024
5507dc2
upgrades mypy
pcrespov Oct 14, 2024
95f2213
ci includes tools
pcrespov Oct 14, 2024
9970d72
fixes mypy with futures
pcrespov Oct 14, 2024
1a0337a
fixes attachment
pcrespov Oct 14, 2024
d0ccdae
fixes attachment and error handling
pcrespov Oct 14, 2024
1b22425
fixes attachment and error handling
pcrespov Oct 14, 2024
e0b8f02
avoids raise if not json-serializable
pcrespov Oct 14, 2024
f75e25d
fixes attachment test
pcrespov Oct 14, 2024
7b3df84
mocks server responses
pcrespov Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ help: ## help on rule's targets


test_python_version: ## Check Python version, throw error if compilation would fail with the installed version
python ./scripts/test_python_version.py
@uv run ./scripts/test_python_version.py


## DOCKER BUILD -------------------------------
Expand Down
2 changes: 1 addition & 1 deletion packages/aws-library/requirements/_tools.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ isort==5.13.2
# pylint
mccabe==0.7.0
# via pylint
mypy==1.11.2
mypy==1.12.0
# via -r requirements/../../../requirements/devenv.txt
mypy-extensions==1.0.0
# via
Expand Down
2 changes: 1 addition & 1 deletion packages/dask-task-models-library/requirements/_tools.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ isort==5.13.2
# pylint
mccabe==0.7.0
# via pylint
mypy==1.11.2
mypy==1.12.0
# via -r requirements/../../../requirements/devenv.txt
mypy-extensions==1.0.0
# via
Expand Down
2 changes: 1 addition & 1 deletion packages/models-library/requirements/_tools.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ mccabe==0.7.0
# via pylint
mdurl==0.1.2
# via markdown-it-py
mypy==1.11.2
mypy==1.12.0
# via -r requirements/../../../requirements/devenv.txt
mypy-extensions==1.0.0
# via
Expand Down
3 changes: 2 additions & 1 deletion packages/models-library/src/models_library/utils/_original_fastapi_encoders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# pylint: disable-all

#
# wget https://raw.githubusercontent.com/tiangolo/fastapi/master/fastapi/encoders.py --output-document=_original_fastapi_encoders
#
Expand Down Expand Up @@ -75,7 +76,7 @@ def jsonable_encoder(
sqlalchemy_safe=sqlalchemy_safe,
)
if dataclasses.is_dataclass(obj):
obj_dict = dataclasses.asdict(obj) # type: ignore[call-overload]
obj_dict = dataclasses.asdict(obj) # type: ignore[arg-type]
return jsonable_encoder(
obj_dict,
include=include,
Expand Down
2 changes: 1 addition & 1 deletion packages/notifications-library/requirements/_test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ idna==3.10
# requests
iniconfig==2.0.0
# via pytest
mypy==1.11.2
mypy==1.12.0
# via sqlalchemy
mypy-extensions==1.0.0
# via mypy
Expand Down
2 changes: 1 addition & 1 deletion packages/notifications-library/requirements/_tools.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ isort==5.13.2
# pylint
mccabe==0.7.0
# via pylint
mypy==1.11.2
mypy==1.12.0
# via
# -c requirements/_test.txt
# -r requirements/../../../requirements/devenv.txt
Expand Down
2 changes: 1 addition & 1 deletion packages/postgres-database/requirements/_test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ greenlet==3.1.1
# sqlalchemy
iniconfig==2.0.0
# via pytest
mypy==1.11.2
mypy==1.12.0
# via sqlalchemy
mypy-extensions==1.0.0
# via mypy
Expand Down
2 changes: 1 addition & 1 deletion packages/postgres-database/requirements/_tools.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ isort==5.13.2
# pylint
mccabe==0.7.0
# via pylint
mypy==1.11.2
mypy==1.12.0
# via
# -c requirements/_test.txt
# -r requirements/../../../requirements/devenv.txt
Expand Down
2 changes: 1 addition & 1 deletion packages/service-integration/requirements/_tools.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ isort==5.13.2
# pylint
mccabe==0.7.0
# via pylint
mypy==1.11.2
mypy==1.12.0
# via -r requirements/../../../requirements/devenv.txt
mypy-extensions==1.0.0
# via
Expand Down
2 changes: 1 addition & 1 deletion packages/service-library/requirements/_test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ multidict==6.1.0
# -c requirements/_base.txt
# aiohttp
# yarl
mypy==1.11.2
mypy==1.12.0
# via sqlalchemy
mypy-extensions==1.0.0
# via mypy
Expand Down
2 changes: 1 addition & 1 deletion packages/service-library/requirements/_tools.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ isort==5.13.2
# pylint
mccabe==0.7.0
# via pylint
mypy==1.11.2
mypy==1.12.0
# via
# -c requirements/_test.txt
# -r requirements/../../../requirements/devenv.txt
Expand Down
2 changes: 1 addition & 1 deletion packages/settings-library/requirements/_tools.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ isort==5.13.2
# pylint
mccabe==0.7.0
# via pylint
mypy==1.11.2
mypy==1.12.0
# via -r requirements/../../../requirements/devenv.txt
mypy-extensions==1.0.0
# via
Expand Down
2 changes: 1 addition & 1 deletion packages/simcore-sdk/requirements/_test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ multidict==6.1.0
# -c requirements/_base.txt
# aiohttp
# yarl
mypy==1.11.2
mypy==1.12.0
# via sqlalchemy
mypy-extensions==1.0.0
# via mypy
Expand Down
2 changes: 1 addition & 1 deletion packages/simcore-sdk/requirements/_tools.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ isort==5.13.2
# pylint
mccabe==0.7.0
# via pylint
mypy==1.11.2
mypy==1.12.0
# via
# -c requirements/_test.txt
# -r requirements/../../../requirements/devenv.txt
Expand Down
2 changes: 2 additions & 0 deletions services/agent/requirements/_base.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,8 @@ referencing==0.29.3
# -c requirements/../../../packages/service-library/requirements/./constraints.txt
# jsonschema
# jsonschema-specifications
repro-zipfile==0.3.1
# via -r requirements/../../../packages/service-library/requirements/_base.in
requests==2.32.3
# via opentelemetry-exporter-otlp-proto-http
rich==13.8.1
Expand Down
2 changes: 1 addition & 1 deletion services/agent/requirements/_tools.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ isort==5.13.2
# pylint
mccabe==0.7.0
# via pylint
mypy==1.11.2
mypy==1.12.0
# via -r requirements/../../../requirements/devenv.txt
mypy-extensions==1.0.0
# via
Expand Down
2 changes: 1 addition & 1 deletion services/api-server/requirements/_test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ multidict==6.0.5
# -c requirements/_base.txt
# aiohttp
# yarl
mypy==1.11.2
mypy==1.12.0
# via sqlalchemy
mypy-extensions==1.0.0
# via mypy
Expand Down
2 changes: 1 addition & 1 deletion services/api-server/requirements/_tools.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ markupsafe==2.1.5
# jinja2
mccabe==0.7.0
# via pylint
mypy==1.11.2
mypy==1.12.0
# via
# -c requirements/_test.txt
# -r requirements/../../../requirements/devenv.txt
Expand Down
2 changes: 1 addition & 1 deletion services/autoscaling/requirements/_tools.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ isort==5.13.2
# pylint
mccabe==0.7.0
# via pylint
mypy==1.11.2
mypy==1.12.0
# via -r requirements/../../../requirements/devenv.txt
mypy-extensions==1.0.0
# via
Expand Down
2 changes: 1 addition & 1 deletion services/catalog/requirements/_test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ multidict==6.0.5
# -c requirements/_base.txt
# aiohttp
# yarl
mypy==1.11.2
mypy==1.12.0
# via sqlalchemy
mypy-extensions==1.0.0
# via mypy
Expand Down
2 changes: 1 addition & 1 deletion services/catalog/requirements/_tools.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ isort==5.13.2
# pylint
mccabe==0.7.0
# via pylint
mypy==1.11.2
mypy==1.12.0
# via
# -c requirements/_test.txt
# -r requirements/../../../requirements/devenv.txt
Expand Down
2 changes: 1 addition & 1 deletion services/clusters-keeper/requirements/_tools.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ isort==5.13.2
# pylint
mccabe==0.7.0
# via pylint
mypy==1.11.2
mypy==1.12.0
# via -r requirements/../../../requirements/devenv.txt
mypy-extensions==1.0.0
# via
Expand Down
2 changes: 1 addition & 1 deletion services/dask-sidecar/requirements/_tools.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ isort==5.13.2
# pylint
mccabe==0.7.0
# via pylint
mypy==1.11.2
mypy==1.12.0
# via -r requirements/../../../requirements/devenv.txt
mypy-extensions==1.0.0
# via
Expand Down
2 changes: 1 addition & 1 deletion services/datcore-adapter/requirements/_tools.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ isort==5.13.2
# pylint
mccabe==0.7.0
# via pylint
mypy==1.11.2
mypy==1.12.0
# via -r requirements/../../../requirements/devenv.txt
mypy-extensions==1.0.0
# via
Expand Down
2 changes: 1 addition & 1 deletion services/director-v2/requirements/_test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ multidict==6.0.5
# aiohttp
# async-asgi-testclient
# yarl
mypy==1.11.2
mypy==1.12.0
# via sqlalchemy
mypy-extensions==1.0.0
# via mypy
Expand Down
2 changes: 1 addition & 1 deletion services/director-v2/requirements/_tools.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ isort==5.13.2
# pylint
mccabe==0.7.0
# via pylint
mypy==1.11.2
mypy==1.12.0
# via
# -c requirements/_test.txt
# -r requirements/../../../requirements/devenv.txt
Expand Down
2 changes: 1 addition & 1 deletion services/dynamic-scheduler/requirements/_tools.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ isort==5.13.2
# pylint
mccabe==0.7.0
# via pylint
mypy==1.11.2
mypy==1.12.0
# via -r requirements/../../../requirements/devenv.txt
mypy-extensions==1.0.0
# via
Expand Down
2 changes: 1 addition & 1 deletion services/dynamic-sidecar/requirements/_test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ multidict==6.0.5
# aiohttp
# async-asgi-testclient
# yarl
mypy==1.11.2
mypy==1.12.0
# via sqlalchemy
mypy-extensions==1.0.0
# via mypy
Expand Down
2 changes: 1 addition & 1 deletion services/dynamic-sidecar/requirements/_tools.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ isort==5.13.2
# pylint
mccabe==0.7.0
# via pylint
mypy==1.11.2
mypy==1.12.0
# via
# -c requirements/_test.txt
# -r requirements/../../../requirements/devenv.txt
Expand Down
2 changes: 1 addition & 1 deletion services/efs-guardian/requirements/_tools.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ isort==5.13.2
# pylint
mccabe==0.7.0
# via pylint
mypy==1.11.2
mypy==1.12.0
# via -r requirements/../../../requirements/devenv.txt
mypy-extensions==1.0.0
# via
Expand Down
2 changes: 1 addition & 1 deletion services/invitations/requirements/_tools.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ isort==5.13.2
# pylint
mccabe==0.7.0
# via pylint
mypy==1.11.2
mypy==1.12.0
# via -r requirements/../../../requirements/devenv.txt
mypy-extensions==1.0.0
# via
Expand Down
2 changes: 1 addition & 1 deletion services/migration/requirements/_test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jsonschema==4.23.0
# via -r requirements/_test.in
jsonschema-specifications==2023.12.1
# via jsonschema
mypy==1.11.2
mypy==1.12.0
# via sqlalchemy
mypy-extensions==1.0.0
# via mypy
Expand Down
2 changes: 1 addition & 1 deletion services/migration/requirements/_tools.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ isort==5.13.2
# pylint
mccabe==0.7.0
# via pylint
mypy==1.11.2
mypy==1.12.0
# via
# -c requirements/_test.txt
# -r requirements/../../../requirements/devenv.txt
Expand Down
2 changes: 1 addition & 1 deletion services/osparc-gateway-server/requirements/_test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ multidict==6.0.5
# -c requirements/_base.txt
# aiohttp
# yarl
mypy==1.11.2
mypy==1.12.0
# via sqlalchemy
mypy-extensions==1.0.0
# via mypy
Expand Down
2 changes: 1 addition & 1 deletion services/osparc-gateway-server/requirements/_tools.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ isort==5.13.2
# pylint
mccabe==0.7.0
# via pylint
mypy==1.11.2
mypy==1.12.0
# via
# -c requirements/_test.txt
# -r requirements/../../../requirements/devenv.txt
Expand Down
2 changes: 1 addition & 1 deletion services/osparc-gateway-server/tests/system/requirements/_tools.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ isort==5.13.2
# pylint
mccabe==0.7.0
# via pylint
mypy==1.11.2
mypy==1.12.0
# via -r requirements/../../../../../requirements/devenv.txt
mypy-extensions==1.0.0
# via
Expand Down
2 changes: 1 addition & 1 deletion services/payments/requirements/_test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ multidict==6.0.5
# -c requirements/_base.txt
# aiohttp
# yarl
mypy==1.11.2
mypy==1.12.0
# via sqlalchemy
mypy-extensions==1.0.0
# via mypy
Expand Down
2 changes: 1 addition & 1 deletion services/payments/requirements/_tools.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ isort==5.13.2
# pylint
mccabe==0.7.0
# via pylint
mypy==1.11.2
mypy==1.12.0
# via
# -c requirements/_test.txt
# -r requirements/../../../requirements/devenv.txt
Expand Down
2 changes: 1 addition & 1 deletion services/resource-usage-tracker/requirements/_test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ moto==5.0.15
# via -r requirements/_test.in
mpmath==1.3.0
# via sympy
mypy==1.11.2
mypy==1.12.0
# via sqlalchemy
mypy-extensions==1.0.0
# via mypy
Expand Down
2 changes: 1 addition & 1 deletion services/resource-usage-tracker/requirements/_tools.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ isort==5.13.2
# pylint
mccabe==0.7.0
# via pylint
mypy==1.11.2
mypy==1.12.0
# via
# -c requirements/_test.txt
# -r requirements/../../../requirements/devenv.txt
Expand Down
2 changes: 1 addition & 1 deletion services/storage/requirements/_test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ multidict==6.0.5
# -c requirements/_base.txt
# aiohttp
# yarl
mypy==1.11.2
mypy==1.12.0
# via sqlalchemy
mypy-extensions==1.0.0
# via mypy
Expand Down
2 changes: 1 addition & 1 deletion services/storage/requirements/_tools.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ isort==5.13.2
# pylint
mccabe==0.7.0
# via pylint
mypy==1.11.2
mypy==1.12.0
# via
# -c requirements/_test.txt
# -r requirements/../../../requirements/devenv.txt
Expand Down
Loading
Loading