-
Notifications
You must be signed in to change notification settings - Fork 32
♻️ Migrates folders and workspaces repositories to asyncpg #6688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Migrates folders and workspaces repositories to asyncpg #6688
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6688 +/- ##
==========================================
- Coverage 87.94% 85.33% -2.62%
==========================================
Files 1569 614 -955
Lines 63156 30998 -32158
Branches 2116 265 -1851
==========================================
- Hits 55542 26451 -29091
+ Misses 7289 4486 -2803
+ Partials 325 61 -264
Continue to review full report in Codecov by Sentry.
|
services/web/server/src/simcore_service_webserver/folders/_folders_db.py
Outdated
Show resolved
Hide resolved
matusdrobuliak66
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful 👍
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, thanks.
services/web/server/src/simcore_service_webserver/folders/_folders_db.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/folders/_folders_db.py
Outdated
Show resolved
Hide resolved
bisgaard-itis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 cool, thanks!
GitHK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll wait for the changes then
dcf6d20 to
f37b9c0
Compare
services/web/server/src/simcore_service_webserver/folders/_folders_db.py
Outdated
Show resolved
Hide resolved
512d89e to
b658b83
Compare
services/web/server/src/simcore_service_webserver/folders/_folders_db.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/folders/_folders_db.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/folders/_folders_db.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/folders/_folders_db.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/workspaces/_groups_db.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/workspaces/_groups_db.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/workspaces/_groups_db.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/workspaces/_workspaces_db.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/workspaces/_workspaces_db.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/workspaces/_workspaces_db.py
Outdated
Show resolved
Hide resolved
bisgaard-itis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the effort!
36a9d2b to
64f4337
Compare
|



What do these changes do?
This PR migrates the
foldersandworkspacesrepository layers to the newasyncpgengine. It also leverages the newutils_repohelpers to support building unit-of-work context managers.Related issue/s
How to test
Dev-ops checklist
NOne