Skip to content

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Nov 7, 2024

What do these changes do?

This PR migrates the folders and workspaces repository layers to the new asyncpg engine. It also leverages the new utils_repo helpers to support building unit-of-work context managers.

Related issue/s

How to test

cd services/web/server
make install-dev
make test-dev-unit

Dev-ops checklist

NOne

@pcrespov pcrespov self-assigned this Nov 7, 2024
@codecov
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 69.69697% with 20 lines in your changes missing coverage. Please review.

Project coverage is 85.33%. Comparing base (2af7f21) to head (64f4337).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6688      +/-   ##
==========================================
- Coverage   87.94%   85.33%   -2.62%     
==========================================
  Files        1569      614     -955     
  Lines       63156    30998   -32158     
  Branches     2116      265    -1851     
==========================================
- Hits        55542    26451   -29091     
+ Misses       7289     4486    -2803     
+ Partials      325       61     -264     
Flag Coverage Δ
integrationtests 64.86% <21.21%> (-0.07%) ⬇️
unittests 87.20% <69.69%> (+1.31%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.44% <ø> (-7.84%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 76.78% <ø> (-14.15%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.79% <ø> (ø)
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.68% <ø> (-5.47%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 88.71% <69.69%> (-0.64%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2af7f21...64f4337. Read the comment docs.

@pcrespov pcrespov added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Nov 7, 2024
@pcrespov pcrespov changed the title ♻️ Is468/update repo folders ♻️ Migrates folders and workspaces repositories to asyncpg Nov 7, 2024
@pcrespov pcrespov added this to the Event Horizon milestone Nov 7, 2024
@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Nov 7, 2024
@pcrespov pcrespov marked this pull request as ready for review November 7, 2024 22:46
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 👍

@pcrespov pcrespov requested a review from GitHK November 8, 2024 09:02
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks.

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 cool, thanks!

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait for the changes then

@pcrespov pcrespov force-pushed the is468/update-repo-folders branch from dcf6d20 to f37b9c0 Compare November 11, 2024 09:13
@pcrespov pcrespov requested a review from GitHK November 11, 2024 09:40
@pcrespov pcrespov enabled auto-merge (squash) November 11, 2024 09:41
@pcrespov pcrespov force-pushed the is468/update-repo-folders branch from 512d89e to b658b83 Compare November 11, 2024 12:15
@pcrespov pcrespov requested a review from GitHK November 11, 2024 12:16
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the effort!

@pcrespov pcrespov force-pushed the is468/update-repo-folders branch from 36a9d2b to 64f4337 Compare November 11, 2024 17:34
@pcrespov pcrespov requested a review from GitHK November 11, 2024 17:35
@sonarqubecloud
Copy link

@pcrespov pcrespov merged commit 8f182d3 into ITISFoundation:master Nov 11, 2024
82 of 89 checks passed
@pcrespov pcrespov deleted the is468/update-repo-folders branch November 11, 2024 19:10
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants