Skip to content

🐛 [Frontend] pydanticV2: Decimals are now Strings #6853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 27, 2024
Merged

🐛 [Frontend] pydanticV2: Decimals are now Strings #6853

merged 7 commits into from
Nov 27, 2024

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Nov 27, 2024 •
edited
Loading

What do these changes do?

  • credit_cost
  • credit_amount
  • osparc_credits
  • current_cost_per_unit
  • price_dollars
  • available_credits

Bonus

  • add attributes to iframe to allow clipboard operations

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz changed the title 🐛 [Frontend] Since pydantic v2 Decimal are nos Strings 🐛 [Frontend] Since pydantic v2 Decimal are now Strings Nov 27, 2024
@odeimaiz odeimaiz changed the title 🐛 [Frontend] Since pydantic v2 Decimal are now Strings 🐛 [Frontend] Since pydantic v2 Decimals are now Strings Nov 27, 2024
@odeimaiz odeimaiz marked this pull request as ready for review November 27, 2024 15:08
@odeimaiz odeimaiz changed the title 🐛 [Frontend] Since pydantic v2 Decimals are now Strings 🐛 [Frontend] pydanticV2: Decimals are now Strings Nov 27, 2024
@odeimaiz odeimaiz self-assigned this Nov 27, 2024
@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Nov 27, 2024
@odeimaiz odeimaiz added this to the Event Horizon milestone Nov 27, 2024
matusdrobuliak66
matusdrobuliak66 approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

jsaq007
jsaq007 approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@giancarloromeo giancarloromeo mentioned this pull request Nov 27, 2024
Merged
1 task
@odeimaiz odeimaiz enabled auto-merge (squash) November 27, 2024 15:24
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@odeimaiz odeimaiz merged commit e7af162 into ITISFoundation:master Nov 27, 2024
52 checks passed
@odeimaiz odeimaiz deleted the fix/decimals-are-now-strings branch November 27, 2024 16:26
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Dec 10, 2024
Closed
17 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
Closed
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@ignapas ignapas Awaiting requested review from ignapas

@GitHK GitHK Awaiting requested review from GitHK

@pcrespov pcrespov Awaiting requested review from pcrespov

@sanderegg sanderegg Awaiting requested review from sanderegg

+1 more reviewer

@jsaq007 jsaq007 jsaq007 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@odeimaiz odeimaiz

Labels

a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected

Projects

None yet

Milestone

Event Horizon

Development

Successfully merging this pull request may close these issues.

4 participants

@odeimaiz @giancarloromeo @jsaq007 @matusdrobuliak66